From: Michael Wookey <michaelwookey@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH] fast-import.c: Silence build warning
Date: Mon, 31 Aug 2009 21:21:34 +1000 [thread overview]
Message-ID: <d2e97e800908310421u7de8ae58o361bd64a026384bf@mail.gmail.com> (raw)
gcc 4.3.3 (Ubuntu 9.04) warns that the return value of strtoul() was not
checked by issuing the following notice:
warning: ignoring return value of ‘strtoul’, declared with attribute
warn_unused_result
Provide a dummy variable to keep the compiler happy.
Signed-off-by: Michael Wookey <michaelwookey@gmail.com>
---
fast-import.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fast-import.c b/fast-import.c
index 7ef9865..1386e75 100644
--- a/fast-import.c
+++ b/fast-import.c
@@ -1744,10 +1744,11 @@ static int validate_raw_date(const char *src,
char *result, int maxlen)
{
const char *orig_src = src;
char *endp;
+ unsigned long int unused;
errno = 0;
- strtoul(src, &endp, 10);
+ unused = strtoul(src, &endp, 10);
if (errno || endp == src || *endp != ' ')
return -1;
@@ -1755,7 +1756,7 @@ static int validate_raw_date(const char *src,
char *result, int maxlen)
if (*src != '-' && *src != '+')
return -1;
- strtoul(src + 1, &endp, 10);
+ unused = strtoul(src + 1, &endp, 10);
if (errno || endp == src || *endp || (endp - orig_src) >= maxlen)
return -1;
--
1.6.4.2.236.gf324c
next reply other threads:[~2009-08-31 11:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 11:21 Michael Wookey [this message]
2009-08-31 12:29 ` [PATCH] fast-import.c: Silence build warning Sverre Rabbelier
2009-08-31 21:27 ` Alex Riesen
2009-08-31 21:42 ` Sverre Rabbelier
2009-08-31 23:31 ` Michael Wookey
2009-08-31 23:42 ` Junio C Hamano
2009-08-31 23:55 ` Michael Wookey
2009-09-01 4:06 ` Stephen Boyd
2009-09-01 6:30 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2e97e800908310421u7de8ae58o361bd64a026384bf@mail.gmail.com \
--to=michaelwookey@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).