From: Michael Wookey <michaelwookey@gmail.com>
To: Marius Storm-Olsen <mstormo@gmail.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>, git@vger.kernel.org
Subject: Re: [PATCH] compat/mingw.c: MSVC build must use ANSI Win32 API's
Date: Tue, 22 Sep 2009 19:17:25 +1000 [thread overview]
Message-ID: <d2e97e800909220217y5bda4698pc286711a3535f87d@mail.gmail.com> (raw)
In-Reply-To: <4AB87B6B.1070808@gmail.com>
2009/9/22 Marius Storm-Olsen <mstormo@gmail.com>:
> Michael, how are you trying to compile git? With the IDE or
> the GNU Make? Which version of MSVC? If you use the IDE, can
> you make sure it doesn't contain the UNICODE define in the
> compiler section of the properties of the projects?
I'm using the VS 2008 Professional IDE (the solution doesn't open in
VS 2005). I made no changes to the build settings. In the Preprocessor
section of the project, UNICODE is defined.
On another note, I see *many* build warnings for things like
"signed/unsigned compares". I'd be willing to work through these
warnings and fix them. Thoughts?
next prev parent reply other threads:[~2009-09-22 9:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 4:10 [PATCH] compat/mingw.c: MSVC build must use ANSI Win32 API's Michael Wookey
2009-09-22 6:08 ` Johannes Sixt
2009-09-22 7:23 ` Marius Storm-Olsen
2009-09-22 9:17 ` Michael Wookey [this message]
2009-09-22 9:40 ` Marius Storm-Olsen
2009-09-22 9:54 ` Michael Wookey
2009-09-23 4:43 ` Michael Wookey
2009-09-28 6:45 ` Johannes Sixt
2009-09-28 7:47 ` Michael Wookey
2009-09-28 8:10 ` Johannes Sixt
2009-09-28 9:50 ` Michael Wookey
2009-09-28 9:55 ` Michael Wookey
2009-09-28 10:21 ` Marius Storm-Olsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2e97e800909220217y5bda4698pc286711a3535f87d@mail.gmail.com \
--to=michaelwookey@gmail.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=mstormo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).