git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Wookey <michaelwookey@gmail.com>
To: Marius Storm-Olsen <mstormo@gmail.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] compat/mingw.c: MSVC build must use ANSI Win32 API's
Date: Wed, 23 Sep 2009 14:43:31 +1000	[thread overview]
Message-ID: <d2e97e800909222143y2cb3b37bq7f6d018c06934ab8@mail.gmail.com> (raw)
In-Reply-To: <d2e97e800909220254sc677abeia220c19f6ef5bd28@mail.gmail.com>

2009/9/22 Michael Wookey <michaelwookey@gmail.com>:
> 2009/9/22 Marius Storm-Olsen <mstormo@gmail.com>:
>>> On another note, I see *many* build warnings for things like
>>> "signed/unsigned compares". I'd be willing to work through these warnings
>>> and fix them. Thoughts?
>>
>> Well, first find out why these are a problem with MSVC and not GCC. Are the
>> types different on these platforms? signed vs unsigned should show up with
>> GCC as well. We need to make sure that we don't fix signed/unsigned issues
>> on one platform, just to introduce it to another platform.
>> In any case, it would be good for someone to have a look at these, just so
>> we can determine the cause for most of them, and then we should figure out
>> on the list how to deal with them.
>
> Well, at warning level 4, MSVC is quite verbose. Perhaps the current
> gcc build flags are more forgiving?

Ah, gcc does produces similar warnings when "-Wextra" is added to the CFLAGS:

  CFLAGS = -g -O2 -Wall -Wextra

IMHO, warnings such as these should be worked through and fixed, or
there may be some latent bug waiting to appear.

  reply	other threads:[~2009-09-23  4:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-22  4:10 [PATCH] compat/mingw.c: MSVC build must use ANSI Win32 API's Michael Wookey
2009-09-22  6:08 ` Johannes Sixt
2009-09-22  7:23   ` Marius Storm-Olsen
2009-09-22  9:17     ` Michael Wookey
2009-09-22  9:40       ` Marius Storm-Olsen
2009-09-22  9:54         ` Michael Wookey
2009-09-23  4:43           ` Michael Wookey [this message]
2009-09-28  6:45           ` Johannes Sixt
2009-09-28  7:47             ` Michael Wookey
2009-09-28  8:10               ` Johannes Sixt
2009-09-28  9:50                 ` Michael Wookey
2009-09-28  9:55                   ` Michael Wookey
2009-09-28 10:21                     ` Marius Storm-Olsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2e97e800909222143y2cb3b37bq7f6d018c06934ab8@mail.gmail.com \
    --to=michaelwookey@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.sixt@viscovery.net \
    --cc=mstormo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).