From: Phillip Wood <phillip.wood123@gmail.com>
To: Jeff King <peff@peff.net>, phillip.wood@dunelm.org.uk
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 0/2] replacing ci/config/allow-ref with a repo variable
Date: Mon, 4 Sep 2023 10:56:15 +0100 [thread overview]
Message-ID: <d3d1109b-3a1f-4e8b-be8d-6581d45f1b81@gmail.com> (raw)
In-Reply-To: <20230901173214.GA1947546@coredump.intra.peff.net>
On 01/09/2023 18:32, Jeff King wrote:
> On Fri, Sep 01, 2023 at 02:24:59PM +0100, Phillip Wood wrote:
>
>> On 30/08/2023 20:49, Jeff King wrote:
>>> This is a more efficient way to do the same thing that
>>> ci/config/allow-ref does (which didn't exist back then).
>>
>> I like the idea of a more efficient way to skip the ci for certain refs.
>> I've got my allow-ref script set up to reject a bunch of refs and run the ci
>> on everything else. It's not clear to me how to replicate that with the
>> setup proposed here. Would it be possible to add a second variable that
>> prevents the ci from being run if it contains ref being pushed?
>
> Drat, I was hoping nobody was using it that way. :)
Sorry to be a pain.
> Yes, I think it would be possible to do something like:
>
> if: |
> (vars.CI_BRANCHES == '' || contains(vars.CI_BRANCHES, github.ref_name)) &&
> !contains(vars.CI_BRANCHES_REJECT, github.ref_name)
>
> It doesn't allow globbing, though. Do you need that?
Oh I'd missed that, yes I do. All the globs are prefix matches but I'm
not sure that helps.
Best Wishes
Phillip
> -Peff
next prev parent reply other threads:[~2023-09-04 9:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 19:49 [PATCH 0/2] replacing ci/config/allow-ref with a repo variable Jeff King
2023-08-30 19:51 ` [PATCH 1/2] ci: allow branch selection through "vars" Jeff King
2023-09-03 8:59 ` Johannes Schindelin
2023-09-05 7:30 ` Jeff King
2023-09-05 10:51 ` Johannes Schindelin
2023-09-07 7:47 ` Jeff King
2023-08-30 19:51 ` [PATCH 2/2] ci: deprecate ci/config/allow-ref script Jeff King
2023-08-30 22:55 ` [PATCH 0/2] replacing ci/config/allow-ref with a repo variable Junio C Hamano
2023-09-01 13:24 ` Phillip Wood
2023-09-01 17:32 ` Jeff King
2023-09-04 9:56 ` Phillip Wood [this message]
2023-09-05 7:24 ` Jeff King
2023-09-07 10:04 ` Phillip Wood
2023-09-11 9:36 ` Jeff King
2023-09-13 15:16 ` Phillip Wood
2023-09-14 0:30 ` Jeff King
2023-09-14 0:44 ` Jeff King
2023-09-14 10:49 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3d1109b-3a1f-4e8b-be8d-6581d45f1b81@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).