From: Scott Chacon <schacon@gmail.com>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Sverre Rabbelier <srabbelier@gmail.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
git list <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] pack documentation review updates
Date: Wed, 11 Nov 2009 11:05:14 +0100 [thread overview]
Message-ID: <d411cc4a0911110205j6f3afedw57d2c56fb28dc20@mail.gmail.com> (raw)
In-Reply-To: <20091111171924.6117@nanako3.lavabit.com>
Hey,
On Wed, Nov 11, 2009 at 9:19 AM, Nanako Shiraishi <nanako3@lavabit.com> wrote:
> Update Scott's protocol document according to review comments given by Junio.
>
> * name of "%00" byte is NUL not null;
> * requestee sends current values of its refs, not "known values";
> * consistently use "obj-id";
> * requestor chooses the capabilities it wants to be in effect;
> * pack data is sent after negotiation finishes, not just after "some of
> it is done";
> * what it has is called "its", not "it's";
> * consistently use "flush-pkt";
> * remove redundant "something like";
> * status report for send-pack is sent from the receiver, not from client;
> * don't unnecessarily say "SHOULD NOT" when existing servers can satisify
> "MUST NOT";
> * only one thin pack is sent and thickened;
> * an all-zero value is defined as a zero-id, so use it.
>
> Signed-off-by: しらいし ななこ <nanako3@lavabit.com>
> ---
I was _just_ working on this yesterday and had gotten about halfway
through - I'm traveling a lot right now, so I'm a bit behind. This
looks good, thanks for taking the time Nanako.
Signed-off-by: Scott Chacon <schacon@gmail.com>
next prev parent reply other threads:[~2009-11-11 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 5:58 [PATCH] Update packfile transfer protocol documentation Scott Chacon
2009-11-04 6:36 ` Sverre Rabbelier
2009-11-05 5:24 ` Junio C Hamano
[not found] ` <20091111171924.6117@nanako3.lavabit.com>
2009-11-11 10:05 ` Scott Chacon [this message]
2009-11-15 9:11 ` [PATCH 2/2] pack documentation review updates Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d411cc4a0911110205j6f3afedw57d2c56fb28dc20@mail.gmail.com \
--to=schacon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nanako3@lavabit.com \
--cc=spearce@spearce.org \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).