From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 607071F403 for ; Tue, 19 Jun 2018 15:21:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966466AbeFSPVN (ORCPT ); Tue, 19 Jun 2018 11:21:13 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:44187 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965783AbeFSPVM (ORCPT ); Tue, 19 Jun 2018 11:21:12 -0400 Received: by mail-qk0-f195.google.com with SMTP id 185-v6so27122qkk.11 for ; Tue, 19 Jun 2018 08:21:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=jZp1Hjd+xzwdYHbhQF3BQN8antbeMSfQGICdComKzfk=; b=Xz+7Lq3du5b/3/YwKGUUE40M8y4oUPx9GzJtEn+AGGjFrD4iAastjgGDpS3QeR4ZSb jocJGc70qkvKZjx8Zhgbi6WnRsYEcoXyqSq6zazYJnVgFGC5Sw9Y9PCQW+A8X+0sbmpS olNIt1Oy0rZQH9myq/rZzR+zt/FI8jYw3yKKJX9sSzrL/75D4teYgTO9kIIy1IBP6eHL NJ28GbOl12j3C+3nYzqxEj1/5q+GJtXLXSvd/SY5gZu2MiFR3v9ImRQcIx46H2BRV2Mt SBYyGNud5y/BaxeDeqYLgORTYt8TKWPvzxjS4f8hSVazQDuPCtz2K2qC+VeHZpK3xw2T W0BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=jZp1Hjd+xzwdYHbhQF3BQN8antbeMSfQGICdComKzfk=; b=TgsJMC8Gb1dWWyrsGajSjnDijA/pdC0ytTNCEmvyFOqyIF+ZMDm4BhDeM421Lx3l72 ZM/vhRZQpa8YTFBPJycsT55C+T3nko0XjdFXkTXo9ISQqIcTVtRM8fSmSXdGXlhN8axe xTmWKBQ3jOfDQDuzh6WqIc3qeET+UtGarYtZp2Ms7+kxHcOrAv6HSjOBn2JDvf3Pg6Pq EUMS3AHF1Jg2C9wM3FJ4fLTtW5jQj4yLBQrIZOQNPBpq0yplDIf+xOw51S4278Tm6w1R jv9ZlqsGmIlItFGYzOhgBJV1W4orHUf56S+nZUFKXrxUyW6y4npbDD4kaOMWC1GI2BKH 6kXA== X-Gm-Message-State: APt69E3hnM8cbQz7fLcYBfcJWrNHEbJ5V1gqJwyByII4eVkZHS3E/fQf CIrEO34KPwSiB+3Er8xWi2Y= X-Google-Smtp-Source: ADUXVKICFPIb8+7ac8c3j4xqkIn+BQwMxj0a8x9RDd5R96fUCQHeq3pIwsWSepd9hDhQcxMaAG0Q8Q== X-Received: by 2002:a37:59c3:: with SMTP id n186-v6mr14187418qkb.132.1529421671359; Tue, 19 Jun 2018 08:21:11 -0700 (PDT) Received: from ?IPv6:2001:4898:6808:13e:d807:51c7:6f48:91e4? ([2001:4898:8010:0:c13d:51c7:6f48:91e4]) by smtp.gmail.com with ESMTPSA id a8-v6sm11347030qtb.15.2018.06.19.08.21.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jun 2018 08:21:10 -0700 (PDT) Subject: Re: [PATCH 01/15] contrib: add cocci script to replace index compat macros To: Duy Nguyen Cc: Git Mailing List , =?UTF-8?Q?SZEDER_G=c3=a1bor?= References: <20180619114143.206568-1-dstolee@microsoft.com> From: Derrick Stolee Message-ID: Date: Tue, 19 Jun 2018 11:21:09 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 6/19/2018 10:51 AM, Duy Nguyen wrote: > On Tue, Jun 19, 2018 at 1:41 PM Derrick Stolee wrote: >> Duy, >> >> Here is the patch that was generated by `make coccicheck`. >> >> Thanks, >> -Stolee >> >> -->8-- >> >> --- builtin/add.c > Ah right. This is on purpose. I think I mentioned in the commit > message that builtin/ is not touched. Do we run 'make coccicheck' > automatically somewhere? If true, I need to move this script elsewhere > because it's meant to run manually. You run it when you intend to do > more manual fixups afterwards. For builtin/, I think I'll wait until > 'struct repository *' conversion is complete then maybe fix them one > by one. I don't think it is part of the CI runs, but some community members run this themselves on 'next' and 'master'. I'm CC'ing Szeder, as he has contributed a fix to my own Coccinelle script [1]. [1] https://public-inbox.org/git/20180430093153.13040-1-szeder.dev@gmail.com/     [PATCH] coccinelle: avoid wrong transformation suggestions from commit.cocci