From: "Nathan W. Panike" <nathan.panike@gmail.com>
To: "Alexander Potashev" <aspotashev@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] format-patch: avoid generation of empty patches
Date: Sat, 10 Jan 2009 10:01:00 -0600 [thread overview]
Message-ID: <d77df1110901100801s463bb43bt701a95df14f167d8@mail.gmail.com> (raw)
In-Reply-To: <20090110113903.GB25723@myhost>
Hi:
On Sat, Jan 10, 2009 at 5:39 AM, Alexander Potashev
<aspotashev@gmail.com> wrote:
...
>
> + if (!commit->parents && !rev.show_root_diff)
> + break;
Do you really want to stop getting commits? It seems like the break
statement here should be a continue.
Nathan Panike
next prev parent reply other threads:[~2009-01-10 16:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 21:33 [PATCH] Get format-patch to show first commit after root commit Nathan W. Panike
2009-01-10 0:49 ` Junio C Hamano
2009-01-10 1:37 ` Nathan W. Panike
2009-01-10 11:36 ` Alexander Potashev
2009-01-10 11:39 ` [PATCH] format-patch: avoid generation of empty patches Alexander Potashev
2009-01-10 16:01 ` Nathan W. Panike [this message]
2009-01-10 16:17 ` Alexander Potashev
2009-01-10 18:07 ` Nathan W. Panike
2009-01-10 20:41 ` Junio C Hamano
2009-01-10 16:39 ` [PATCH] Add new testcases for format-patch root commits Alexander Potashev
2009-01-10 18:33 ` Alexander Potashev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d77df1110901100801s463bb43bt701a95df14f167d8@mail.gmail.com \
--to=nathan.panike@gmail.com \
--cc=aspotashev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).