From: "Nathan W. Panike" <nathan.panike@gmail.com>
To: "Alexander Potashev" <aspotashev@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] format-patch: avoid generation of empty patches
Date: Sat, 10 Jan 2009 12:07:06 -0600 [thread overview]
Message-ID: <d77df1110901101007o1d17142aub6971b72ba55c89e@mail.gmail.com> (raw)
In-Reply-To: <20090110161722.GA18859@myhost>
Hi:
On Sat, Jan 10, 2009 at 10:17 AM, Alexander Potashev
<aspotashev@gmail.com> wrote:
...
> AFAIU get_revision stops revision iteration when it appears to stay at
> the root commit. So, if we will replace 'break' with 'continue', the
> 'while' loop will finish right after that 'continue'.
> However, I might be wrong... please, correct me then.
I was thinking of the case where there is more than one root. Maybe
the code does the right thing then, but I confess I have not looked at
it deeply enough to know.
Nathan Panike
next prev parent reply other threads:[~2009-01-10 18:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 21:33 [PATCH] Get format-patch to show first commit after root commit Nathan W. Panike
2009-01-10 0:49 ` Junio C Hamano
2009-01-10 1:37 ` Nathan W. Panike
2009-01-10 11:36 ` Alexander Potashev
2009-01-10 11:39 ` [PATCH] format-patch: avoid generation of empty patches Alexander Potashev
2009-01-10 16:01 ` Nathan W. Panike
2009-01-10 16:17 ` Alexander Potashev
2009-01-10 18:07 ` Nathan W. Panike [this message]
2009-01-10 20:41 ` Junio C Hamano
2009-01-10 16:39 ` [PATCH] Add new testcases for format-patch root commits Alexander Potashev
2009-01-10 18:33 ` Alexander Potashev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d77df1110901101007o1d17142aub6971b72ba55c89e@mail.gmail.com \
--to=nathan.panike@gmail.com \
--cc=aspotashev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).