git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: public git mailing list <git@vger.kernel.org>
Cc: Paul Mackerras <paulus@ozlabs.org>
Subject: gitk feature requests: (1) "diff.orderFile" and (2) "--function-context"
Date: Sun, 23 Feb 2020 16:06:19 +0100	[thread overview]
Message-ID: <d972c1f1-c49a-f644-ab1c-6a3e26c43ee3@redhat.com> (raw)

Hello,

as of commit c1a63459ed73 ("gitk: Preserve window dimensions on exit
when not using ttk themes", 2019-12-15), gitk seems to lack two features
that I consider "killer" ones, for reviewing patches (including my own
patches, of course):

- support for the "--function-context" ("-W") option,
- support for the "-O<orderfile>" (aka "diff.orderFile") setting.

These flags are in fact mentioned in the gitk source code, going back to
historical commit ee66e089c1d4 ("gitk: Make updates go faster", 2008-05-09).

The options are stashed in vdflags($n), and then summarily ignored. A
comment says, "These request or affect diff output, which we don't
want", and I don't understand why; I would very much like them, please :)

Why I'm not proposing patches myself: my knowledge of Tcl/Tk is weaker
than my knowledge of Perl. My knowledge of Perl is... well, let's change
the topic. :) I have basically zero idea what "gitk" source does, for
the most part.

Could someone please write gitk patches for honoring "diff.orderFile"
and "--function-context"?

Accepting "--find-copies-harder" too would be the icing on the cake.

Thank you!
Laszlo


                 reply	other threads:[~2020-02-23 15:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d972c1f1-c49a-f644-ab1c-6a3e26c43ee3@redhat.com \
    --to=lersek@redhat.com \
    --cc=git@vger.kernel.org \
    --cc=paulus@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).