From: "jayesh0104 via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>,
Jayesh Daga <jayeshdaga99@gmail.com>,
jayesh0104 <jayeshdaga99@gmail.com>
Subject: [PATCH 1/2] t/pack-refs-tests: drop '-f' from test_path_is_missing
Date: Sun, 22 Mar 2026 12:46:25 +0000 [thread overview]
Message-ID: <d9fff1ad4effb57fc0c814bee7b33c84ee40f7ca.1774183586.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.2247.git.git.1774183586.gitgitgadget@gmail.com>
From: jayesh0104 <jayeshdaga99@gmail.com>
test_path_is_missing expects exactly one argument: the path to
check for absence. Passing '-f' is incorrect and results in
"bug in the test script: 1 param" during test execution.
The '-f' flag appears to have been carried over from the
equivalent 'test -f' usage, but test_path_is_missing does not
accept such flags.
Remove the extraneous '-f' to use the helper correctly and
restore proper test behavior.
Signed-off-by: Jayesh Daga <jayeshdaga99@gmail.com>
---
t/pack-refs-tests.sh | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
mode change 100644 => 100755 t/pack-refs-tests.sh
diff --git a/t/pack-refs-tests.sh b/t/pack-refs-tests.sh
old mode 100644
new mode 100755
index 2fdaccb6c7..8a0c955647
--- a/t/pack-refs-tests.sh
+++ b/t/pack-refs-tests.sh
@@ -1,3 +1,9 @@
+#!/bin/sh
+
+test_description='test pack-refs'
+
+. ./test-lib.sh
+
pack_refs=${pack_refs:-pack-refs}
test_expect_success 'enable reflogs' '
@@ -61,7 +67,7 @@ test_expect_success 'see if a branch still exists after git ${pack_refs} --prune
test_expect_success 'see if git ${pack_refs} --prune remove ref files' '
git branch f &&
git ${pack_refs} --all --prune &&
- ! test -f .git/refs/heads/f
+ test_path_is_missing .git/refs/heads/f
'
test_expect_success 'see if git ${pack_refs} --prune removes empty dirs' '
--
gitgitgadget
next prev parent reply other threads:[~2026-03-22 12:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 12:46 [PATCH 0/2] t/pack-refs-tests: fix helper usage Jayesh Daga via GitGitGadget
2026-03-22 12:46 ` jayesh0104 via GitGitGadget [this message]
2026-03-22 12:46 ` [PATCH 2/2] t/pack-refs-tests: drop '-f' from test_path_is_missing jayesh0104 via GitGitGadget
2026-03-22 13:29 ` K Jayatheerth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9fff1ad4effb57fc0c814bee7b33c84ee40f7ca.1774183586.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=jayatheerthkulkarni2005@gmail.com \
--cc=jayeshdaga99@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox