From: "Mark Ryden" <markryde@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: white spaces in a patch
Date: Wed, 17 Dec 2008 13:44:01 +0200 [thread overview]
Message-ID: <dac45060812170344u368ffd7fx4e86253b4a13ffc7@mail.gmail.com> (raw)
In-Reply-To: <7vej07p84i.fsf@gitster.siamese.dyndns.org>
Hello,
I tried:
git apply patch1.txt
patch1.txt:34: trailing whitespace.
patch1.txt:53: trailing whitespace.
And
"git diff" show differences but **does not**
highlight anything.
I tried in tchs and in Bash.
Any ideas ? does "git diff" does highlight for anyone ?
Rgs,
Mark
On Wed, Dec 17, 2008 at 9:34 AM, Junio C Hamano <gitster@pobox.com> wrote:
> "Mark Ryden" <markryde@gmail.com> writes:
>
>> 1) Is there a way to check whether there are white spaces in this
>> file without running git-apply?
>
> "sed -n -e '/^+.*[ ]$/p' patch.txt" perhaps?
>
>> 2) Is there a way to get some messages about that there are white spaces
>> when creating a git patch?
>
> Doesn't "git diff" highlight whitespace errors? That way, you can catch
> errors before you make a commit that has them.
>
next prev parent reply other threads:[~2008-12-17 11:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 7:31 white spaces in a patch Mark Ryden
2008-12-17 7:34 ` Junio C Hamano
2008-12-17 11:44 ` Mark Ryden [this message]
2008-12-17 12:13 ` Sverre Rabbelier
2008-12-17 12:13 ` Mark Ryden
2008-12-17 12:15 ` Thomas Jarosch
2008-12-17 12:22 ` Mark Ryden
2008-12-17 20:02 ` Matthieu Moy
2008-12-17 12:22 ` Jeff King
2008-12-17 12:16 ` Sverre Rabbelier
2008-12-17 12:08 ` Johannes Schindelin
2008-12-17 12:10 ` Mark Ryden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dac45060812170344u368ffd7fx4e86253b4a13ffc7@mail.gmail.com \
--to=markryde@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).