From: Vladimir Panteleev <thecybershadow@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] show-ref: Allow --head to work with --verify
Date: Sat, 21 Jan 2017 00:25:36 +0000 [thread overview]
Message-ID: <daef1407-6f08-147d-e23b-bb69bb8fd1ed@gmail.com> (raw)
In-Reply-To: <xmqqo9z1ux7r.fsf@gitster.mtv.corp.google.com>
On 2017-01-20 23:29, Junio C Hamano wrote:
> By the way, I have no strong preference between "read-ref, check
> quiet and show-one" and "show-ref", so if you make --verify to
> consistently call "show_ref()" for both refs/heads/master and HEAD,
> that is also perfectly fine.
This sounds like a good idea, as it will also allow -d and some other
options to work with --verify (whatever use case there might be for
that). Will resubmit with that.
> I just do not want to see the same feature/codepath to call two
> different implementations that happens to do the same thing today.
Understood and agreed.
--
Best regards,
Vladimir
prev parent reply other threads:[~2017-01-21 0:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 15:50 [PATCH] show-ref: Allow --head to work with --verify Vladimir Panteleev
2017-01-20 19:03 ` Junio C Hamano
2017-01-20 20:26 ` Vladimir Panteleev
2017-01-20 20:51 ` Vladimir Panteleev
2017-01-20 22:22 ` Junio C Hamano
2017-01-20 22:31 ` Junio C Hamano
2017-01-20 23:15 ` Junio C Hamano
2017-01-20 22:55 ` Vladimir Panteleev
2017-01-20 23:20 ` Junio C Hamano
2017-01-20 23:29 ` Junio C Hamano
2017-01-21 0:25 ` Vladimir Panteleev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daef1407-6f08-147d-e23b-bb69bb8fd1ed@gmail.com \
--to=thecybershadow@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).