From: Sebastian Kuzminsky <seb@highlab.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: bug in 'git describe'?
Date: Tue, 25 Sep 2018 09:39:43 -0600 [thread overview]
Message-ID: <dbd2dcef-c892-3628-119e-f688e74f3599@highlab.com> (raw)
In-Reply-To: <xmqqefdir0tz.fsf@gitster-ct.c.googlers.com>
On 9/24/18 4:24 PM, Junio C Hamano wrote:
> Sebastian Kuzminsky <seb@highlab.com> writes:
>
>> I've got two tiny git repos whose commit graphs are identical, but
>> where 'git describe' gives different results. ... The histories
>> differ only in the timestamps of the commits...
>
> describe does take the commit timestamps into account, so it is
> expected you would get different results out of an otherwise
> identically looking graph.
Thanks for that confirmation.
That behavior seems to me to be different from what the (2.11) manpage says:
> it suffixes the tag name with the number of additional commits on top
> of the tagged object
And:
> If multiple tags were found during the walk then the tag which has
> the fewest commits different from the input commit-ish will be
> selected and output. Here fewest commits different is defined as the
> number of commits which would be shown by git log tag..input will be
> the smallest number of commits possible.
All that said, if you consider this "working as expected" then i'm
content to let the matter drop.
--
Sebastian Kuzminsky
next prev parent reply other threads:[~2018-09-25 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 21:45 bug in 'git describe'? Sebastian Kuzminsky
2018-09-24 22:24 ` Junio C Hamano
2018-09-25 15:39 ` Sebastian Kuzminsky [this message]
2018-09-25 16:05 ` Duy Nguyen
2018-09-25 16:10 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbd2dcef-c892-3628-119e-f688e74f3599@highlab.com \
--to=seb@highlab.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).