From: Derrick Stolee <stolee@gmail.com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>, git@vger.kernel.org
Cc: Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH v2] commit-reach: avoid is_descendant_of() shim
Date: Tue, 23 Jun 2020 14:53:57 -0400 [thread overview]
Message-ID: <dbd85d9a-6fc9-1187-0268-d28e532ec507@gmail.com> (raw)
In-Reply-To: <20200623184222.54201-1-carenas@gmail.com>
On 6/23/2020 2:42 PM, Carlo Marcelo Arenas Belón wrote:
> d91d6fbf26 (commit-reach: create repo_is_descendant_of(), 2020-06-17)
> adds a repository aware version of is_descendant_of() and a backward
> compatibility shim that is barely used.
>
> Update all callers to directly use the new repo_is_descendant_of()
> function instead; making the codebase simpler and pushing more
> the_repository references higher up the stack.
Thanks for the update! This version looks good to me.
-Stolee
prev parent reply other threads:[~2020-06-23 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 8:17 [PATCH] commit-reach: avoid is_dependant_of() shim Carlo Marcelo Arenas Belón
2020-06-23 12:59 ` Derrick Stolee
2020-06-23 18:42 ` [PATCH v2] commit-reach: avoid is_descendant_of() shim Carlo Marcelo Arenas Belón
2020-06-23 18:53 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbd85d9a-6fc9-1187-0268-d28e532ec507@gmail.com \
--to=stolee@gmail.com \
--cc=carenas@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).