From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de, ki.stfu@gmail.com
Subject: Re: [PATCH] fsmonitor: invalidate untracked cache after losing history
Date: Thu, 5 Nov 2026 10:02:27 -0500 [thread overview]
Message-ID: <dbdf0592-6819-4063-b62d-22e2d6df1050@gmail.com> (raw)
In-Reply-To: <3d62a579-5bf1-4431-8bfc-757c3c873d80@gmail.com>
On 11/5/2026 9:08 AM, Derrick Stolee wrote:
> On 11/4/2026 5:52 PM, Junio C Hamano wrote:
>> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>>> A user of an internal monorepo reported this behavior, including an
>>> AI-assisted powershell script to prove how it worked. I used an agent to
>>> assist in porting that to a Git test script and a code fix, but then
>>> applied significant human editing and validation on top to get it up to
>>> my standards.
>>>
>>> Thanks, -Stolee
>>
>> Would this be a viable replacement for ik/fsmonitor-untracked-cache-trivial-response
>>
>> https://lore.kernel.org/git/pull.2247.git.1791127155614.gitgitgadget@gmail.com/
>>
>> that has been left unreviewed for a month?
>
> Thank you for pointing me at this. I didn't realize there was already a
> patch working on a fix for this issue.
>
> Ilia's patch has the stronger approach of trying to preserve as much of
> the untracked cache as possible, which has some performance improvements
> over my change (in the "rare" case of the fsmonitor failing).
>
> Let me first see if we can take that patch instead of mine. I'll start
> some review over there.
Review complete. We should take Ilia's patch instead of mine. Consider this
patch retracted.
Thanks,
-Stolee
next prev parent reply other threads:[~2026-11-05 15:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 15:37 [PATCH] fsmonitor: invalidate untracked cache after losing history Derrick Stolee via GitGitGadget
2026-11-04 20:39 ` Junio C Hamano
2026-11-04 22:52 ` Junio C Hamano
2026-11-05 14:08 ` Derrick Stolee
2026-11-05 15:02 ` Derrick Stolee [this message]
2026-11-05 17:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbdf0592-6819-4063-b62d-22e2d6df1050@gmail.com \
--to=stolee@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=ki.stfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox