From: "Nikolai Weibull" <now@bitwi.se>
To: "David Rientjes" <rientjes@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 28/28] makes upload_pack void
Date: Tue, 15 Aug 2006 00:45:20 +0200 [thread overview]
Message-ID: <dbfc82860608141545s3e75457eo4be1201395e24354@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.63.0608141340060.19383@chino.corp.google.com>
On 8/14/06, David Rientjes <rientjes@google.com> wrote:
> Makes upload_pack void and removes conditional return.
> -static int upload_pack(void)
> +static void upload_pack(void)
I don't know for sure, but I'm guessing the intention was to be able
to return a failing code /if/ there ever was a condition where
upload_pack() would fail, e.g., if send_ref() would return a status
code instead of die():ing if it can't parse the given sha1. In a
future libification, the change of return type may have to be
reverted.
nikolai
next prev parent reply other threads:[~2006-08-14 22:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-14 20:40 [PATCH 28/28] makes upload_pack void David Rientjes
2006-08-14 22:45 ` Nikolai Weibull [this message]
2006-08-14 22:51 ` David Rientjes
2006-08-14 23:03 ` Nikolai Weibull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbfc82860608141545s3e75457eo4be1201395e24354@mail.gmail.com \
--to=now@bitwi.se \
--cc=git@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).