git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nikolai Weibull" <now@bitwi.se>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "Junio C Hamano" <junkio@cox.net>, git <git@vger.kernel.org>
Subject: Re: git-check-ref-format returns 1 for valid branch names
Date: Thu, 22 Mar 2007 22:58:07 +0100	[thread overview]
Message-ID: <dbfc82860703221458j690d1cafve01174eda8f149ee@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0703221358420.6730@woody.linux-foundation.org>

On 3/22/07, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
>
> On Thu, 22 Mar 2007, Junio C Hamano wrote:
>
> > "Nikolai Weibull" <now@bitwi.se> writes:
> >
> > > I'm obviously doing something wrong, but in git 1.5.0.4
> > >
> > > % git check-ref-format abc
> > > % echo $?
> > > 1
> > >
> > > What am I missing here?
> >
> > If you are trying to see if abc is a valid branch name, try refs/heads/abc.
>
> .. and before anybody wonders why it wants the "fully qualified" name,
> it's because "abc" on its own is ambiguous. Is it a _tag_ called "abc", or
> a branch, or what? That explains why - if you really want to verify a
> ref-name, you need to give the full name..
>
> On the other hand, if you don't care, and you just want "is this a valid
> commit name", use
>
>         sha1=$(git rev-parse --verify "$name"^0) || exit

Thanks for the clarification.

What I was after was a way to verify that a name is a valid new name
of a branch, for the Zsh completion definition in the context of
git-checkout -b <new_branch>. [1]  After posting I realized that
perhaps checking out the sources for git-checkout would enlighten me,
which it did, as it uses git-check-ref-format "heads/$newbranch" to
verify that the new branch's name  is valid.

[1] It's not really going to try to complete anything here, but verify
that the new branch's name is valid while the user types it in. [2]
[2]  Hm, perhaps completing existing branch-names makes more sense,
allowing the user to create a new branch-name based on an old one.

      reply	other threads:[~2007-03-22 21:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-22 20:24 git-check-ref-format returns 1 for valid branch names Nikolai Weibull
2007-03-22 20:32 ` Junio C Hamano
2007-03-22 20:42   ` Nikolai Weibull
2007-03-22 21:03   ` Linus Torvalds
2007-03-22 21:58     ` Nikolai Weibull [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbfc82860703221458j690d1cafve01174eda8f149ee@mail.gmail.com \
    --to=now@bitwi.se \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).