I forgot my .c file On Fri, Oct 23, 2009 at 4:30 PM, Kevyn-Alexandre Paré wrote: > Thx junio for that analyse! > > So what I understand from what you have said is that the problem is > not in format-patch since that I see white space from git show $commit > ?!: > > history: I was trying to remove coding style problem in > drivers/staging/comedi/drivers/pcl726.c > > ./scripts/checkpatch.pl --terse --file > drivers/staging/comedi/drivers/pcl726.c        #### NO warning after > removing problems > ### git commit -a >                      # was done after that > ### git format-patch -s -n master..pcl726 > > kapare@vostro:~/linux-kernel-patch/linux-2.6$ git show $commit > > TEST.git.show.commit      #### see whitespace in vim > kapare@vostro:~/linux-kernel-patch/linux-2.6$ ./scripts/checkpatch.pl > --terse --file TEST.git.show.commit > TEST:19: ERROR: trailing whitespace > TEST:27: ERROR: trailing whitespace > TEST:35: ERROR: trailing whitespace > TEST:45: ERROR: trailing whitespace > TEST:55: ERROR: trailing whitespace > TEST:60: ERROR: trailing whitespace > TEST:67: ERROR: trailing whitespace > TEST:69: ERROR: trailing whitespace > TEST:80: ERROR: trailing whitespace > TEST:106: ERROR: trailing whitespace > TEST:113: ERROR: trailing whitespace > > So what am I doing wrong? Any clues? see attachment you ask > > thx > > kap > > On Fri, Oct 23, 2009 at 3:52 PM, Junio C Hamano wrote: >> Kevyn-Alexandre Paré   writes: >> >>> Just before I send my patch I got this error with: >>> ./scripts/checkpatch.pl --terse --file >>> 0001-Staging-comedi-driver-fix-coding-style.patch >>> >>> 0001-Staging-comedi-driver-fix-coding-style.patch:27: ERROR: trailing whitespace >>> 0001-Staging-comedi-driver-fix-coding-style.patch:35: ERROR: trailing whitespace >>> 0001-Staging-comedi-driver-fix-coding-style.patch:43: ERROR: trailing whitespace >>> 0001-Staging-comedi-driver-fix-coding-style.patch:53: ERROR: trailing whitespace >>> >>> I have done a step by step explanation of what I have done: >>> http://kapare.blogspot.com/2009/09/write-and-submit-your-first-kernel.html >>> >>> It seem to me that the whitespace are added after I do this command: >>> git format-patch -s -n master..mybranch >> >> "The whitespace are added after..." sounds to me that what you committed >> were checkpatch compliant, and format-patch somehow broke it.  If that is >> the case we need to fix format-patch. >> >> Please check if "git show $commit" output for the commit that corresponds >> to the "[Staging] comedi driver: fix coding style" patch has trailing >> whitespaces.  That is what you committed. >> >> If there already is whitespace breakage in what you committed, then we do >> not have to blame format-patch and look for bugs in it to fix. >> >> Otherwise, please send 0001-*.patch (output from format-patch) and output >> from that "git show $commit" as separate attachments, so that we can debug >> and fix format-patch. >> >> Thanks. >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-newbie" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at  http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.linux-learn.org/faqs >> >