From: "Kevyn-Alexandre Paré" <kevyn.alexandre.pare@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Daniel Barkalow <barkalow@iabervon.org>,
linux-newbie@vger.kernel.org, kernel-janitors@vger.kernel.org,
git@vger.kernel.org
Subject: Re: Write and Submit Your First Kernel Patch
Date: Fri, 23 Oct 2009 17:26:25 -0400 [thread overview]
Message-ID: <dc1d0f40910231426j45184429qbe3531bc76555c77@mail.gmail.com> (raw)
In-Reply-To: <7vskd9akv6.fsf@alter.siamese.dyndns.org>
My mistake but I learn a lot from you guys!
I should simply have done:
./scripts/checkpatch.pl --terse --patch
0001-Staging-comedi-driver-fix-coding-style.patch
or
./scripts/checkpatch.pl --terse --patch
0001-Staging-comedi-driver-fix-coding-style.patch
# Since --patch is the default!
No warning to the output, I will change my blog
thx again
kap
On Fri, Oct 23, 2009 at 4:58 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Daniel Barkalow <barkalow@iabervon.org> writes:
>
>> On Fri, 23 Oct 2009, Kevyn-Alexandre Paré wrote:
>>
>>> Just before I send my patch I got this error with:
>>> ./scripts/checkpatch.pl --terse --file
>>> 0001-Staging-comedi-driver-fix-coding-style.patch
>>
>> You're using checkpatch --file on a patch. I hope you don't intend your
>> patch to be added to the kernel source as a file, but rather applied to
>> the kernel source, changing other files. (I bet "gcc 0001-Staging*.patch"
>> will get interesting errors, too...) The patch format adds a single
>> character at the beginning of each line to say whether it's a addition, a
>> deletion, or a context line, and the context lines are identified by a
>> space character. This means that a blank context line consists of just
>> this space character, which is therefore a trailing space. We get the same
>> type of complaints when we have expected diff output in our test scripts.
>>
>> I'm kind of surprised that checkpatch doesn't completely blow up when it's
>> expecting a source file and getting a patch (and maybe tell you what
>> you've done). But that's the source of your errors, anyway.
>
> Ah, your analysis is correct. This is a usage error of checkpatch script
> and there is nothing for us to worry about.
>
> Thanks; I also failed to spot --file option when I responded.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-newbie" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.linux-learn.org/faqs
prev parent reply other threads:[~2009-10-23 21:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 18:46 Write and Submit Your First Kernel Patch Kevyn-Alexandre Paré
[not found] ` <87zl7hudn4.fsf@erwin.mina86.com>
[not found] ` <dc1d0f40910231219l600d3579i57c7580fe798d445@mail.gmail.com>
2009-10-23 19:41 ` Michal Nazarewicz
2009-10-23 19:52 ` Junio C Hamano
2009-10-23 20:30 ` Kevyn-Alexandre Paré
2009-10-23 20:34 ` Kevyn-Alexandre Paré
2009-10-23 20:33 ` Daniel Barkalow
2009-10-23 20:58 ` Junio C Hamano
2009-10-23 21:26 ` Kevyn-Alexandre Paré [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc1d0f40910231426j45184429qbe3531bc76555c77@mail.gmail.com \
--to=kevyn.alexandre.pare@gmail.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-newbie@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).