From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Kevyn=2DAlexandre_Par=E9?= Subject: Re: Write and Submit Your First Kernel Patch Date: Fri, 23 Oct 2009 17:26:25 -0400 Message-ID: References: <7vskd9akv6.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Daniel Barkalow , linux-newbie@vger.kernel.org, kernel-janitors@vger.kernel.org, git@vger.kernel.org To: Junio C Hamano X-From: linux-newbie-owner@vger.kernel.org Fri Oct 23 23:26:38 2009 Return-path: Envelope-to: lnx-linux-newbie@lo.gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1N1Ref-0000KR-D1 for lnx-linux-newbie@lo.gmane.org; Fri, 23 Oct 2009 23:26:37 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752559AbZJWV0X convert rfc822-to-quoted-printable (ORCPT ); Fri, 23 Oct 2009 17:26:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752073AbZJWV0W (ORCPT ); Fri, 23 Oct 2009 17:26:22 -0400 Received: from mail-iw0-f180.google.com ([209.85.223.180]:51644 "EHLO mail-iw0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751695AbZJWV0V convert rfc822-to-8bit (ORCPT ); Fri, 23 Oct 2009 17:26:21 -0400 Received: by iwn10 with SMTP id 10so4926611iwn.4 for ; Fri, 23 Oct 2009 14:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=R9zmYYUuCGZjdauNpQf22kkiGcz6B/UqBGEX9fJ2LMI=; b=TRWO/5Z4hqIxsm2NiJt0KJLGq0HRibuHK6fw9wAGmzgiz/oc85Tf6iKEzgK8KcYmd8 AYwUbIolOcIn6uRYztaMCclk6qDr4ZGmEIbu+l2jUtTdI6cnlVxETNnLBk/YKnVZFdE6 eG++3vM2nfSSahYuXZ7bdXBhQH00ecbTaBV34= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=e29KPNgf2UPBqFr2ya+vBrF8SNGmZkiXzwuujStyCqS+imKp5dhLm3WVH+EnvRTHB+ bclrT8h0/V02qFmvGk0f+uE/qGcv/6/BWee9ftgFG6NVcfTF6FutJ6Pqf05vTzjeuq3P Cetzyex0FFVDVsl4oCCX6PDxXI8bOQYwLmSuU= Received: by 10.231.124.227 with SMTP id v35mr5798626ibr.18.1256333185959; Fri, 23 Oct 2009 14:26:25 -0700 (PDT) In-Reply-To: <7vskd9akv6.fsf@alter.siamese.dyndns.org> Sender: linux-newbie-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-newbie@vger.kernel.org Archived-At: My mistake but I learn a lot from you guys! I should simply have done: =2E/scripts/checkpatch.pl --terse --patch 0001-Staging-comedi-driver-fix-coding-style.patch or =2E/scripts/checkpatch.pl --terse --patch 0001-Staging-comedi-driver-fix-coding-style.patch # Since --patch is the default! No warning to the output, I will change my blog thx again kap On Fri, Oct 23, 2009 at 4:58 PM, Junio C Hamano wro= te: > Daniel Barkalow writes: > >> On Fri, 23 Oct 2009, Kevyn-Alexandre Par=E9 wrote: >> >>> Just before I send my patch I got this error with: >>> ./scripts/checkpatch.pl --terse --file >>> 0001-Staging-comedi-driver-fix-coding-style.patch >> >> You're using checkpatch --file on a patch. I hope you don't intend y= our >> patch to be added to the kernel source as a file, but rather applied= to >> the kernel source, changing other files. (I bet "gcc 0001-Staging*.p= atch" >> will get interesting errors, too...) The patch format adds a single >> character at the beginning of each line to say whether it's a additi= on, a >> deletion, or a context line, and the context lines are identified by= a >> space character. This means that a blank context line consists of ju= st >> this space character, which is therefore a trailing space. We get th= e same >> type of complaints when we have expected diff output in our test scr= ipts. >> >> I'm kind of surprised that checkpatch doesn't completely blow up whe= n it's >> expecting a source file and getting a patch (and maybe tell you what >> you've done). But that's the source of your errors, anyway. > > Ah, your analysis is correct. =A0This is a usage error of checkpatch = script > and there is nothing for us to worry about. > > Thanks; I also failed to spot --file option when I responded. > -- To unsubscribe from this list: send the line "unsubscribe linux-newbie"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.linux-learn.org/faqs