[PATCH] t/Makefile: remove smoke test targets

[PATCH] t/Makefile: remove smoke test targets

[John Keeping]

Commit d24fbca (Remove Git's support for smoke testing - 2011-12-23)
removed the smoke test support from the test suite but it was re-added
by commit 342e9ef (Introduce a performance testing framework -
2012-02-17).  This appears to be the result of a mis-merge, since
re-adding the smoke testing infrastructure does not relate to the
subject of that commit.

The current 'smoke' target is broken since the 'harness' script it
uses no longer exists, so just reapply this section of commit d24fbca
and remove all of the smoke testing section in the makefile.

Signed-off-by: John Keeping <john@keeping.me.uk>
---
 t/Makefile | 38 --------------------------------------
 1 file changed, 38 deletions(-)

diff --git a/t/Makefile b/t/Makefile
index 1923cc1..44ca7d3 100644
--- a/t/Makefile
+++ b/t/Makefile
@@ -83,42 +83,4 @@ valgrind:
 perf:
 	$(MAKE) -C perf/ all
 
-# Smoke testing targets
--include ../GIT-VERSION-FILE
-uname_S := $(shell sh -c 'uname -s 2>/dev/null || echo unknown')
-uname_M := $(shell sh -c 'uname -m 2>/dev/null || echo unknown')
-
-test-results:
-	mkdir -p test-results
-
-test-results/git-smoke.tar.gz: test-results
-	'$(PERL_PATH_SQ)' ./harness \
-		--archive="test-results/git-smoke.tar.gz" \
-		$(T)
-
-smoke: test-results/git-smoke.tar.gz
-
-SMOKE_UPLOAD_FLAGS =
-ifdef SMOKE_USERNAME
-	SMOKE_UPLOAD_FLAGS += -F username="$(SMOKE_USERNAME)" -F password="$(SMOKE_PASSWORD)"
-endif
-ifdef SMOKE_COMMENT
-	SMOKE_UPLOAD_FLAGS += -F comments="$(SMOKE_COMMENT)"
-endif
-ifdef SMOKE_TAGS
-	SMOKE_UPLOAD_FLAGS += -F tags="$(SMOKE_TAGS)"
-endif
-
-smoke_report: smoke
-	curl \
-		-H "Expect: " \
-		-F project=Git \
-		-F architecture="$(uname_M)" \
-		-F platform="$(uname_S)" \
-		-F revision="$(GIT_VERSION)" \
-		-F report_file=@test-results/git-smoke.tar.gz \
-		$(SMOKE_UPLOAD_FLAGS) \
-		http://smoke.git.nix.is/app/projects/process_add_report/1 \
-	| grep -v ^Redirecting
-
 .PHONY: pre-clean $(T) aggregate-results clean valgrind perf
-- 
1.8.2.1.715.gb260f47

Re: [PATCH] t/Makefile: remove smoke test targets

[Thomas Rast]

John Keeping <john@keeping.me.uk> writes:

> Commit d24fbca (Remove Git's support for smoke testing - 2011-12-23)
> removed the smoke test support from the test suite but it was re-added
> by commit 342e9ef (Introduce a performance testing framework -
> 2012-02-17).  This appears to be the result of a mis-merge, since
> re-adding the smoke testing infrastructure does not relate to the
> subject of that commit.
>
> The current 'smoke' target is broken since the 'harness' script it
> uses no longer exists, so just reapply this section of commit d24fbca
> and remove all of the smoke testing section in the makefile.
>
> Signed-off-by: John Keeping <john@keeping.me.uk>

Indeed.  I must have mis-rebased this commit or some such.

Acked-by: Thomas Rast <trast@inf.ethz.ch>

-- 
Thomas Rast
trast@{inf,student}.ethz.ch