From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: "Felipe Contreras" <felipe.contreras@gmail.com>,
阿德烈 <adlternative@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v2 2/2] parse-options: format argh like error messages
Date: Wed, 6 Jan 2021 07:05:51 -0500 [thread overview]
Message-ID: <dd7d692a-0e78-0e98-6b1d-4157372d6674@gmail.com> (raw)
In-Reply-To: <c5f01b0eab1dd13d46ac344e362cd13e7bc365fc.1609933875.git.gitgitgadget@gmail.com>
On 1/6/2021 6:51 AM, Junio C Hamano via GitGitGadget wrote:
> From: Junio C Hamano <gitster@pobox.com>
>
> "Keep it homogeneous across the repository" is in general a
> guideline that can be used to converge to a good practice, but
> we can be a bit more prescriptive in this case. Just like the
> messages we give die(_("...")) are formatted without the final
> full stop and without the initial capitalization, most of the
> argument help text are already formatted that way, and we want
> to encourage that as the house style.
>
> Noticed-by: ZheNing Hu <adlternative@gmail.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
ZheNing,
It is certainly a common thing to pull patches from other
contributors into your own series. However, you'll need to
add your own sign-off at the end.
I also believe that the intention was that this patch
would come before the other, so please swap the patches.
Then, you can update the message in the other patch from
According to the "Error Messages" section of
Documentation/CodingGuidelines,
to
According to the guidelines in parse-options.h,
Thanks,
-Stolee
next prev parent reply other threads:[~2021-01-06 12:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 8:55 [PATCH] builtin/*: update usage format 阿德烈 via GitGitGadget
2020-12-29 14:33 ` Felipe Contreras
2021-01-06 7:05 ` Re* " Junio C Hamano
2021-01-06 12:03 ` Derrick Stolee
2021-01-06 11:51 ` [PATCH v2 0/2] " 阿德烈 via GitGitGadget
2021-01-06 11:51 ` [PATCH v2 1/2] " ZheNing Hu via GitGitGadget
2021-01-06 11:51 ` [PATCH v2 2/2] parse-options: format argh like error messages Junio C Hamano via GitGitGadget
2021-01-06 12:05 ` Derrick Stolee [this message]
2021-01-06 14:44 ` [PATCH v3 0/2] builtin/*: update usage format 阿德烈 via GitGitGadget
2021-01-06 14:44 ` [PATCH v3 1/2] parse-options: format argh like error messages Junio C Hamano via GitGitGadget
2021-01-06 14:44 ` [PATCH v3 2/2] builtin/*: update usage format ZheNing Hu via GitGitGadget
2021-01-06 23:14 ` [PATCH v3 0/2] " Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2021-01-06 14:16 [PATCH v2 2/2] parse-options: format argh like error messages 胡哲宁
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd7d692a-0e78-0e98-6b1d-4157372d6674@gmail.com \
--to=stolee@gmail.com \
--cc=adlternative@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).