From: Brad Smith <brad@comstyle.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] config.mak.uname: update settings for FreeBSD
Date: Wed, 11 Jun 2025 23:54:11 -0400 [thread overview]
Message-ID: <ddb50b73-8f98-48e5-880b-b991508edea3@comstyle.com> (raw)
In-Reply-To: <xmqqsek5fwnu.fsf@gitster.g>
On 2025-06-11 11:47 p.m., Junio C Hamano wrote:
> Brad Smith <brad@comstyle.com> writes:
>
>> FreeBSD 6.0 has memmem().
> And anything older than that no longer matters?
I look at is as so. 6.0 is 19.5 years old as it is.
> That may indeed be true (6.0 was from Nov 2005), but if that is the
> reason why we simply lose NO_MEMMEM (instead of conditionally losing
> for 6.0 and newer), that needs to be explained in the proposed log
> message, together with the reason why we no longer do anything
> special with version "4.x" (which could be "We ditch the support for
> anything older than 6.0").
>
> Assuming that our stance is "anything older than 6.0 no longer
> matters", the patch itself looks good.
This was my intent. I'll update the commit message.
next prev parent reply other threads:[~2025-06-12 3:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 3:13 [PATCH] config.mak.uname: update settings for FreeBSD Brad Smith
2025-06-12 3:31 ` Collin Funk
2025-06-12 3:46 ` Brad Smith
2025-06-12 3:47 ` Junio C Hamano
2025-06-12 3:54 ` Brad Smith [this message]
2025-07-03 12:40 ` Renato Botelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddb50b73-8f98-48e5-880b-b991508edea3@comstyle.com \
--to=brad@comstyle.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).