From: cpettitt <cpettitt@gmail.com>
To: "Pierre Habouzit" <madcoder@debian.org>,
"Shawn O. Pearce" <spearce@spearce.org>,
cpettitt <cpettitt@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] Fix regression in fast-import.c due to strbufs.
Date: Fri, 26 Oct 2007 09:39:27 -0700 [thread overview]
Message-ID: <de47e4420710260939h65fbf62dg8d1644a5cd879c23@mail.gmail.com> (raw)
In-Reply-To: <20071026075912.GA25365@artemis.corp>
On 10/26/07, Pierre Habouzit <madcoder@debian.org> wrote:
> Without this strbuf_release, it yields a double free later, the command is
> in fact stashed, and this is not a memory leak.
>
> Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre,
You nailed it! No more double frees and no segfault.
Thanks,
Chris
next prev parent reply other threads:[~2007-10-26 16:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <de47e4420710251726nb45a19fk15b3105b735a74f8@mail.gmail.com>
2007-10-26 0:29 ` git-fast-import segfaults cpettitt
2007-10-26 6:53 ` Shawn O. Pearce
2007-10-26 7:59 ` [PATCH] Fix regression in fast-import.c due to strbufs Pierre Habouzit
2007-10-26 16:39 ` cpettitt [this message]
2007-10-26 17:25 ` Pierre Habouzit
2007-10-29 2:59 ` Shun Kei Leung
2007-10-29 6:29 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de47e4420710260939h65fbf62dg8d1644a5cd879c23@mail.gmail.com \
--to=cpettitt@gmail.com \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).