public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Junio C Hamano" <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 2/2] merge/pull: extend merge.stat configuration variable to cover --compact-summary
Date: Fri, 13 Jun 2025 14:09:52 +0200	[thread overview]
Message-ID: <deb4951a-5d1b-416d-bcad-5d675d8155cc@app.fastmail.com> (raw)
In-Reply-To: <20250612222537.2426059-3-gitster@pobox.com>

On Fri, Jun 13, 2025, at 00:25, Junio C Hamano wrote:
> Extend it to be "Boolean or text", that takes false, true, or
> "compact", with the last one triggering the --compact-summary
> option introduced earlier.

Would it make sense to make `diffstat` an alias for `true`?  I’m not
sure since you need to keep `true` anyway so you still have that
historical artifact (?)[1] of `true` meaning `diffstat`.

† 1: In the sense of what was added first

Also

> "compact", with the last one triggering the --compact-summary
> option introduced earlier.

So `merge.stat` can be used instead of `--compact-summary`.  But now the
option does not mention `merge.stat`?

>  `merge.stat`::
> -	Whether to print the diffstat between `ORIG_HEAD` and the merge result
> -	at the end of the merge.  True by default.
> +	What, if anything, to print between `ORIG_HEAD` and the merge result
> +	at the end of the merge.  Possible values are:
> ++
> +--
> +`false`;; Show nothing.
> +`true`;; Show `git diff --diffstat ORIG_HEAD`.
> +`compact`;; Show `git diff --compact-summary ORIG_HEAD`.

I can’t run `git diff --diffstat ORIG_HEAD`.  `--diffstat` is not
an option.

> +If this variable is left unspecified, it defaults to `true`.

I think this is simpler:

    Defaults to `true`.

There’s also several places in this doc which uses something similar
judging by a search for “defaults to”.  Only exception is
`merge.renameLimit`:

    If not specified, defaults to

  reply	other threads:[~2025-06-13 12:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12 22:25 [PATCH v2 0/2] git pull/merge --compact-summary Junio C Hamano
2025-06-12 22:25 ` [PATCH v2 1/2] merge/pull: --compact-summary Junio C Hamano
2025-06-13 12:07   ` Kristoffer Haugsbakk
2025-06-13 16:26     ` Junio C Hamano
2025-06-12 22:25 ` [PATCH v2 2/2] merge/pull: extend merge.stat configuration variable to cover --compact-summary Junio C Hamano
2025-06-13 12:09   ` Kristoffer Haugsbakk [this message]
2025-06-13 16:38     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=deb4951a-5d1b-416d-bcad-5d675d8155cc@app.fastmail.com \
    --to=kristofferhaugsbakk@fastmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox