Git development
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: Jeff King <peff@peff.net>, Peter Eckersley <peter.eckersley@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Weirdness with git change detection
Date: Tue, 11 Jul 2017 10:20:43 +0200	[thread overview]
Message-ID: <decbd316-5194-120d-824e-b5cee1f0822c@web.de> (raw)
In-Reply-To: <20170711073433.ghcz3lku3ux54fib@sigill.intra.peff.net>



On 11/07/17 09:34, Jeff King wrote:
> On Tue, Jul 11, 2017 at 12:31:25AM -0700, Peter Eckersley wrote:
> 
>> I did try to test that hypothesis by editing the filter to be a no-op,
>> but it's possible I go that wrong. My apologies for bugging the list!

Actually I like this kind of feedback, to see how people are using Git,
including the problems they have.

> 
> No problem. I actually think it would be interesting if Git could
> somehow detect and warn about this situation. But the obvious way to do
> that would be to re-run the clean filter directly after checkout. And
> doing that all the time is expensive.

Would it be possible to limit the round-trip-check to "git reset --hard" ?
If yes, possibly many users are willing to pay the price, if Git tells
the "your filters don't round-trip". (Including CRLF conversions)

> 
> Perhaps some kind of "lint" program would be interesting to warn of
> possible misconfigurations. Of course people would have to run it for it
> to be useful. :)

What do you have in mind here ?
Don't we need to run some content through the filter(s)?

  reply	other threads:[~2017-07-11  8:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-10 23:45 Weirdness with git change detection Peter Eckersley
2017-07-11  4:15 ` Torsten Bögershausen
2017-07-11  7:06   ` Jeff King
2017-07-11  7:31     ` Peter Eckersley
2017-07-11  7:34       ` Jeff King
2017-07-11  8:20         ` Torsten Bögershausen [this message]
2017-07-11  8:24           ` Jeff King
2017-08-18  6:56             ` Michael J Gruber
2017-08-18 11:57               ` Jeff King
2017-07-11 15:57 ` Junio C Hamano
2017-07-11 16:04   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=decbd316-5194-120d-824e-b5cee1f0822c@web.de \
    --to=tboegi@web.de \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=peter.eckersley@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox