From: "René Scharfe" <l.s.r@web.de>
To: Jeff King <peff@peff.net>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] cat-file: speed up default format
Date: Mon, 15 Jun 2026 23:53:10 +0200 [thread overview]
Message-ID: <df933ffa-1be2-4401-a4ac-9d72c9c4cdcc@web.de> (raw)
In-Reply-To: <20260615165326.GA91269@coredump.intra.peff.net>
On 6/15/26 6:53 PM, Jeff King wrote:
>
> +static void rest_add(struct format_item *item UNUSED,
> + struct strbuf *sb, struct expand_data *data)
> +{
> + strbuf_addstr(sb, data->rest);
> +}
> } else if (is_atom("rest", atom, len)) {
> - if (data->mark_query)
> - data->split_on_whitespace = 1;
> - else if (data->rest)
This removes support for rest being NULL, breaking t1006.381.
> - strbuf_addstr(sb, data->rest);
> + data->split_on_whitespace = 1;
> + fmt->add = rest_add;
René
prev parent reply other threads:[~2026-06-15 21:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-14 16:28 [PATCH] cat-file: speed up default format René Scharfe
2026-06-15 7:27 ` Patrick Steinhardt
2026-06-15 16:53 ` Jeff King
2026-06-15 17:06 ` Jeff King
2026-06-15 21:53 ` René Scharfe
2026-06-15 21:53 ` René Scharfe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df933ffa-1be2-4401-a4ac-9d72c9c4cdcc@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox