From: "René Scharfe" <l.s.r@web.de>
To: Kristofer Karlsson via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: Kristofer Karlsson <krka@spotify.com>
Subject: Re: [PATCH v3 0/2] prio-queue: use bottom-up sift for extract-min
Date: Fri, 10 Jul 2026 18:37:22 +0200 [thread overview]
Message-ID: <dfab9ff4-fbfa-4ea2-bea3-09c1d1b1cc18@web.de> (raw)
In-Reply-To: <pull.2132.v3.git.1783532989.gitgitgadget@gmail.com>
On 7/8/26 7:49 PM, Kristofer Karlsson via GitGitGadget wrote:
> Note: sift_up() currently uses swap, matching the existing code style. It
> could be further optimized to use copy (hold the element in a temp, shift
> parents down, write once), but that would require changing compare() to
> accept element values instead of array indices. Left for a potential
> follow-up.
Same for sift_down_root(), I guess? It could almost halve the number of
writes, right? I wonder how much of that benefit will be eaten by
caching.
René
next prev parent reply other threads:[~2026-07-10 16:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-31 17:57 [PATCH] prio-queue: use cascade-down sift for faster extract-min Kristofer Karlsson via GitGitGadget
2026-06-01 0:09 ` Junio C Hamano
2026-06-01 6:16 ` Junio C Hamano
2026-06-01 6:21 ` Kristofer Karlsson
2026-06-01 8:17 ` [PATCH v2] prio-queue: use cascade-down " Kristofer Karlsson via GitGitGadget
2026-06-02 16:36 ` René Scharfe
2026-06-02 22:40 ` Kristofer Karlsson
2026-06-05 20:39 ` Kristofer Karlsson
2026-06-07 7:30 ` René Scharfe
2026-06-07 12:07 ` Kristofer Karlsson
2026-06-29 21:16 ` Junio C Hamano
2026-06-08 11:56 ` Junio C Hamano
2026-07-06 21:52 ` Kristofer Karlsson
2026-07-08 10:43 ` René Scharfe
2026-07-08 10:59 ` Kristofer Karlsson
2026-07-08 11:55 ` René Scharfe
2026-07-08 12:44 ` Kristofer Karlsson
2026-07-08 17:49 ` [PATCH v3 0/2] prio-queue: use bottom-up sift for extract-min Kristofer Karlsson via GitGitGadget
2026-07-08 17:49 ` [PATCH v3 1/2] prio-queue: extract sift_up() from prio_queue_put() Kristofer Karlsson via GitGitGadget
2026-07-08 17:49 ` [PATCH v3 2/2] prio-queue: use cascade for unfused gets Kristofer Karlsson via GitGitGadget
2026-07-10 16:37 ` René Scharfe
2026-07-10 17:28 ` Kristofer Karlsson
2026-07-10 16:37 ` René Scharfe [this message]
2026-07-10 17:40 ` [PATCH v3 0/2] prio-queue: use bottom-up sift for extract-min Kristofer Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfab9ff4-fbfa-4ea2-bea3-09c1d1b1cc18@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=krka@spotify.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox