git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rubén Justo" <rjusto@gmail.com>
To: Isoken June Ibizugbe <isokenjune@gmail.com>, git@vger.kernel.org
Cc: christian.couder@gmail.com, Junio C Hamano <gitster@pobox.com>
Subject: Re: [Outreachy][PATCH] branch.c: adjust error messages to coding guidelines
Date: Wed, 18 Oct 2023 20:19:33 +0200	[thread overview]
Message-ID: <e08b2ec4-786a-4c18-b7af-0a6a250ae0f0@gmail.com> (raw)
In-Reply-To: <20231018051223.13955-1-isokenjune@gmail.com>

On 18-oct-2023 06:12:22, Isoken June Ibizugbe wrote:

> Signed-off-by: Isoken June Ibizugbe <isokenjune@gmail.com>
> ---
>  builtin/branch.c | 66 ++++++++++++++++++++++++------------------------
>  1 file changed, 33 insertions(+), 33 deletions(-)

Only builtin/branch.c is touched.

The changes in this patch break some tests, therefore this patch must
also include the fixes for those tests.

> @@ -965,11 +965,11 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
>  		const char *start_name = argc == 2 ? argv[1] : head;
>  
>  		if (filter.kind != FILTER_REFS_BRANCHES)
> -			die(_("The -a, and -r, options to 'git branch' do not take a branch name.\n"
> +			die(_("the -a, and -r, options to 'git branch' do not take a branch name\n"
>  				  "Did you mean to use: -a|-r --list <pattern>?"));

OK.  The initial 'T' is fixed, but as Junio explained [1], the full stop
must stay.


Thanks.

 [1] https://lore.kernel.org/git/xmqqttqxkmaq.fsf@gitster.g/

  reply	other threads:[~2023-10-18 18:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18  5:12 [Outreachy][PATCH] branch.c: adjust error messages to coding guidelines Isoken June Ibizugbe
2023-10-18 18:19 ` Rubén Justo [this message]
2023-10-18 18:44   ` Junio C Hamano
2023-10-19  8:40   ` [PATCH v2] builtin/branch.c: " Isoken June Ibizugbe
2023-10-19 19:20     ` Rubén Justo
2023-10-20 17:31       ` Junio C Hamano
2023-10-20 17:59         ` Isoken Ibizugbe
2023-10-21 10:31         ` Rubén Justo
2023-10-21 10:27       ` Rubén Justo
2023-10-20  4:26     ` Isoken Ibizugbe
2023-10-20  9:41       ` Christian Couder
2023-10-20 17:10         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e08b2ec4-786a-4c18-b7af-0a6a250ae0f0@gmail.com \
    --to=rjusto@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=isokenjune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).