From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Sven Strickroth" <email@cs-ware.de>, git@vger.kernel.org
Subject: Re: [PATCH] Fix duplicate word typos
Date: Sat, 19 Oct 2024 12:06:54 +0200 [thread overview]
Message-ID: <e1ee980d-d8d2-4c9c-9a73-ba6af9009ba2@app.fastmail.com> (raw)
In-Reply-To: <b50f9706-bb45-4bf0-8d32-59149615301b@mrtux-pc.local>
Hi
I guess it was an intentional choice to not use an “area” in the commit
message?
I found this similar patch which used `*` as the area: abcb66c614c (*:
fix typos which duplicate a word, 2021-06-11); review here:
https://lore.kernel.org/git/CAPig+cTjjNrU9q8UPm+CRuTKq8_XNc+1z7-3F4bvetBi+NjKeQ@mail.gmail.com/
On Sat, Oct 19, 2024, at 12:37, Sven Strickroth wrote:
> Used regex to find these typos: "(?<!struct )(?<=\s)([a-z]{1,}) \1(?=\s)"
This would be more conventional:
Used regex to find these typos:
(?<!struct )(?<=\s)([a-z]{1,}) \1(?=\s)
Either that or code fence (MarkDown style).
>
> Signed-off-by: Sven Strickroth <email@cs-ware.de>
I can confirm that this patch only does that. Except:
> ---
> […]
> -Suppose that that central repository has this history:
> +Suppose that the central repository has this history:
Here the doubled “that” is replaced with “the” which makes the sentence
correct. Good.
There are also no grammatically correct “that that” constructs that have
been removed.
> Documentation/RelNotes/2.45.0.txt
I was wondering if typo fixes are done for released-released versions
(not going through RC). But the aforementioned patch abcb66c614c does
fix a release note or two for some old versions.
--
Kristoffer Haugsbakk
next prev parent reply other threads:[~2024-10-19 10:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 10:37 [PATCH] Fix duplicate word typos Sven Strickroth
2024-10-19 10:06 ` Kristoffer Haugsbakk [this message]
2024-10-21 9:47 ` Patrick Steinhardt
2024-10-21 9:57 ` Kristoffer Haugsbakk
2024-10-21 15:12 ` [PATCH v2] global: " Sven Strickroth
2024-10-22 5:07 ` Patrick Steinhardt
2024-10-21 20:04 ` [PATCH] " Taylor Blau
2024-10-21 20:05 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1ee980d-d8d2-4c9c-9a73-ba6af9009ba2@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail.com \
--cc=email@cs-ware.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).