From: "René Scharfe" <l.s.r@web.de>
To: lolligerhans@gmx.de
Cc: git@vger.kernel.org
Subject: Re: [PATCH] diff: allow --color-moved with --no-ext-diff
Date: Sun, 23 Jun 2024 11:46:43 +0200 [thread overview]
Message-ID: <e23dc86c-e32d-40f9-8305-86d4a25e79b6@web.de> (raw)
In-Reply-To: <trinity-5166e20d-147e-4205-99b7-f13a007ed5f9-1719134235233@3c-app-gmx-bap30>
Am 23.06.24 um 11:17 schrieb lolligerhans@gmx.de:
> using red/green coloration is the current buggy behavior. When
> setting oldMOved and newMoved I would expect the correct behaviour to
> the the same as the buggy one.
>
> Could this test pass despite the bug?
Good question, but it doesn't. The test uses the colors "normal red"
and "normal green" for moved lines, i.e. unchanged text color on red and
green background, while regular changed lines use red and green text on
unchanged background.
René
next prev parent reply other threads:[~2024-06-23 9:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 10:01 Bug: diff.external --no-ext-diff suppresses --color-moved lolligerhans
2024-06-22 19:41 ` [PATCH] diff: allow --color-moved with --no-ext-diff René Scharfe
2024-06-23 9:17 ` Aw: " lolligerhans
2024-06-23 9:46 ` René Scharfe [this message]
2024-06-24 16:21 ` Junio C Hamano
2024-06-24 19:15 ` René Scharfe
2024-06-25 0:39 ` Junio C Hamano
2024-06-24 19:15 ` [PATCH v2] " René Scharfe
2024-06-24 20:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e23dc86c-e32d-40f9-8305-86d4a25e79b6@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=lolligerhans@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).