git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Mike Ralphson" <mike.ralphson@gmail.com>
To: "H.Merijn Brand" <h.m.brand@xs4all.nl>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] opening files in remote.c should ensure it is opening a file
Date: Fri, 8 Feb 2008 17:25:52 +0000	[thread overview]
Message-ID: <e2b179460802080925s61270036q81896010c76236ae@mail.gmail.com> (raw)
In-Reply-To: <20080208174654.2e9e679c@pc09.procura.nl>

On Feb 8, 2008 4:46 PM, H.Merijn Brand <h.m.brand@xs4all.nl> wrote:
> HP-UX allows directories to be opened with fopen (path, "r"), which
> will cause some translations that expect to read files, read dirs
> instead. This patch makes sure the two fopen () calls in remote.c
> only open the file if it is a file.
>
> Signed-off-by: H.Merijn Brand <h.m.brand@xs4all.nl>

Many thanks, this is also required for AIX. I had got some way to
tracking it down, but I thought it was an issue with strbuf. So...

Tested-by: Mike Ralphson <mike.ralphson@gmail.com>

Your other fix there [- if (!strbuf_avail(sb)) / + if
(strbuf_avail(sb) < 64) ] is, guess what, also required on AIX.

Thanks again.

  reply	other threads:[~2008-02-08 17:26 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08 16:46 [PATCH] opening files in remote.c should ensure it is opening a file H.Merijn Brand
2008-02-08 17:25 ` Mike Ralphson [this message]
2008-02-08 20:04   ` H.Merijn Brand
2008-02-18  9:10     ` H.Merijn Brand
2008-02-18  9:30       ` Junio C Hamano
2008-02-18 11:31         ` H.Merijn Brand
2008-02-08 20:36   ` Daniel Barkalow
2008-02-08 20:44     ` Johannes Schindelin
2008-02-09  5:27     ` Junio C Hamano
2008-02-09  5:54       ` Daniel Barkalow
2008-02-08 20:09 ` Junio C Hamano
2008-02-08 20:38   ` Johannes Schindelin
2008-02-09 10:03   ` H.Merijn Brand
2008-02-08 20:15 ` Morten Welinder
2008-02-08 20:33   ` Junio C Hamano
2008-02-08 20:40     ` Johannes Schindelin
2008-02-08 21:19       ` Junio C Hamano
2008-02-08 21:47         ` Johannes Schindelin
2008-02-08 20:58     ` Brandon Casey
2008-02-08 21:14       ` Brandon Casey
2008-02-09  5:12       ` Junio C Hamano
2008-02-09  1:20     ` Brandon Casey
2008-02-09  2:32       ` [PATCH] Add compat/fopen.c which returns NULL on attempt to open directory Brandon Casey
2008-02-11  9:29         ` H.Merijn Brand
2008-02-11 10:15           ` H.Merijn Brand
2008-02-12  0:20             ` Junio C Hamano
2008-02-12 15:27               ` H.Merijn Brand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2b179460802080925s61270036q81896010c76236ae@mail.gmail.com \
    --to=mike.ralphson@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=h.m.brand@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).