From: "Mike Ralphson" <mike.ralphson@gmail.com>
To: "Brandon Casey" <casey@nrlssc.navy.mil>,
"H.Merijn Brand" <h.m.brand@xs4all.nl>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Johannes Sixt" <j.sixt@viscovery.net>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] compat/fopen.c: avoid clobbering the system defined fopen macro
Date: Thu, 8 May 2008 08:27:48 +0100 [thread overview]
Message-ID: <e2b179460805080027pf9ff518xf4fcbb248ecac4bf@mail.gmail.com> (raw)
In-Reply-To: <4821E81A.4030600@nrlssc.navy.mil>
2008/5/7 Brandon Casey <casey@nrlssc.navy.mil>:
>
> Some systems define fopen as a macro based on compiler settings.
> The previous technique for reverting to the system fopen function
> by merely undefining fopen is inadequate in this case. Instead,
> avoid defining fopen entirely when compiling this source file.
>
> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
>
Tested-by: Mike Ralphson <mike@abacus.co.uk>
Both with and without -D_LARGE_FILES. Many thanks.
H.Merijn, is this change also ok for your HP-UX?
I guess there may still be a case for not defining _LARGE_FILES by
default on AIX as all the warnings may be off-putting or mask other
issues. Maybe instead having a comment for those who need large
pack-file support? Will submit amended Makefile patch if there's
interest.
Mike
next prev parent reply other threads:[~2008-05-08 7:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 8:35 [PATCH] Makefile: update the default build options for AIX Mike Ralphson
2008-05-07 11:57 ` Johannes Sixt
2008-05-07 12:51 ` Mike Ralphson
2008-05-07 13:05 ` Mike Ralphson
2008-05-07 13:14 ` Johannes Sixt
2008-05-07 14:20 ` Mike Ralphson
2008-05-07 14:38 ` Brandon Casey
2008-05-07 15:15 ` Mike Ralphson
2008-05-07 15:39 ` Johannes Sixt
2008-05-07 15:40 ` Brandon Casey
2008-05-07 16:04 ` Junio C Hamano
2008-05-07 16:20 ` Mike Ralphson
2008-05-07 17:36 ` Brandon Casey
2008-05-07 17:34 ` [PATCH] compat/fopen.c: avoid clobbering the system defined fopen macro Brandon Casey
2008-05-08 7:27 ` Mike Ralphson [this message]
2008-05-08 7:34 ` Johannes Sixt
2008-05-08 7:59 ` Mike Ralphson
2008-05-08 10:37 ` H.Merijn Brand
2008-05-16 10:19 ` [PATCH] Makefile: update the default build options for AIX Mike Ralphson
2008-05-16 13:37 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2b179460805080027pf9ff518xf4fcbb248ecac4bf@mail.gmail.com \
--to=mike.ralphson@gmail.com \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=h.m.brand@xs4all.nl \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).