From: "Mike Ralphson" <mike.ralphson@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Paolo Bonzini" <bonzini@gnu.org>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Git mailing list" <git@vger.kernel.org>
Subject: Re: [PATCH v2] rollback lock files on more signals than just SIGINT
Date: Thu, 5 Jun 2008 09:02:02 +0100 [thread overview]
Message-ID: <e2b179460806050102m1ca15b2fj61d32ca45e4770d4@mail.gmail.com> (raw)
In-Reply-To: <7vhcc9xg5j.fsf@gitster.siamese.dyndns.org>
2008/6/4 Junio C Hamano <gitster@pobox.com>:
> "Mike Ralphson" <mike.ralphson@gmail.com> writes:
>
>> 2008/5/29 Paolo Bonzini <bonzini@gnu.org>:
>> ...
>> This addition to the testsuite breaks it on AIX with the default sh
>> (ksh). Replacing the explicit sh -c with $SHELL_PATH -c fixes it for
>> me (as I have SHELL_PATH pointing to bash). If that's acceptable I can
>> post a patch if necessary.
>
> Like the attached one?
Yes, something like that 8-) Thanks for applying. Actually getting
patches out from my work domain without the egregious disclaimer, and
to get them to actually show up in the list is still a bit of a faff
here.
> I noticed quite a many "sh" dependencies in other test scripts:
I'm happy to pick up a bit of janitor work on the tests after this
release. I notice we have a few non-executable test scripts, and
several 'duplicate' test numbers which might also want to be looked
at?
Cheers, Mike
prev parent reply other threads:[~2008-06-05 8:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 8:03 [PATCH] rollback index if git-commit is interrupted by a signal Paolo Bonzini
2008-05-29 12:42 ` Johannes Schindelin
2008-05-29 13:19 ` Paolo Bonzini
2008-05-29 14:03 ` Johannes Schindelin
2008-05-29 14:35 ` Paolo Bonzini
2008-05-29 14:42 ` Johannes Schindelin
2008-05-29 14:55 ` [PATCH v2] rollback lock files on more signals than just SIGINT Paolo Bonzini
2008-06-04 11:40 ` Mike Ralphson
2008-06-04 17:29 ` Junio C Hamano
2008-06-05 8:02 ` Mike Ralphson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2b179460806050102m1ca15b2fj61d32ca45e4770d4@mail.gmail.com \
--to=mike.ralphson@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=bonzini@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).