From: "Mike Ralphson" <mike.ralphson@gmail.com>
To: "Robin Rosenberg" <robin.rosenberg.lists@dewire.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
"Marek Zawirski" <marek.zawirski@gmail.com>,
git@vger.kernel.org
Subject: Re: [JGIT PATCH 1/1] jgit: create a tag command
Date: Thu, 10 Jul 2008 16:31:06 +0100 [thread overview]
Message-ID: <e2b179460807100831g5d62a0a8nc7e7bf2715f0b9f1@mail.gmail.com> (raw)
In-Reply-To: <200807070116.39892.robin.rosenberg.lists@dewire.com>
2008/7/7 Robin Rosenberg <robin.rosenberg.lists@dewire.com>:
>
> This command allows us to create simple or annotated tags.
> PGP signed tags are not yet supported.
>
> Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
Apologies this will be whitespace damaged, but it's trivial.
diff --git a/org.spearce.jgit/src/org/spearce/jgit/pgm/Tag.java
b/org.spearce.jgit/src/org/spearce/jgit/pgm/Tag.java
index 110db6b..a215fbd 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/pgm/Tag.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/pgm/Tag.java
@@ -47,6 +47,8 @@ class Tag extends TextBuiltin {
String message = null;
String ref = "HEAD";
boolean force = false;
+ if (args.length == 0)
+ usage();
for (int i = 0; i < args.length; ++i) {
if (args[i].equals("-f")) {
force = true;
@@ -97,6 +99,6 @@ class Tag extends TextBuiltin {
}
private void usage() {
- throw die("Usage: -m message tag [head]");
+ throw die("Usage: [-m message] [-f] tag [head]");
}
}
Signed-off-by: Mike Ralphson <mike@abacus.co.uk>
Loving the make_jgit stuff.
Mike
next prev parent reply other threads:[~2008-07-10 15:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-06 22:41 [JGIT PATCH 1/1] jgit: create a tag command Robin Rosenberg
2008-07-06 23:16 ` Robin Rosenberg
2008-07-10 15:31 ` Mike Ralphson [this message]
2008-07-10 18:02 ` Robin Rosenberg
2008-07-11 10:50 ` Differences between git-applu and GNU patch (was: [JGIT PATCH 1/1] jgit: create a tag command) Jakub Narebski
2008-07-11 2:05 ` [JGIT PATCH 1/1] jgit: create a tag command Shawn O. Pearce
2008-07-11 8:28 ` Robin Rosenberg
2008-07-11 8:45 ` Mike Ralphson
2008-07-12 3:01 ` Shawn O. Pearce
2008-07-12 3:42 ` Shawn O. Pearce
2008-07-17 21:31 ` Robin Rosenberg
2008-07-17 21:45 ` Shawn O. Pearce
2008-07-17 22:24 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2b179460807100831g5d62a0a8nc7e7bf2715f0b9f1@mail.gmail.com \
--to=mike.ralphson@gmail.com \
--cc=git@vger.kernel.org \
--cc=marek.zawirski@gmail.com \
--cc=robin.rosenberg.lists@dewire.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).