Re: [RFC/PATCH] Use compatibility regex library for OSX/Darwin

["Mike Ralphson" <mike.ralphson@gmail.com>]

2008/9/10 Mike Ralphson <mike.ralphson@gmail.com>:
> 2008/9/10 Arjen Laarhoven <arjen@yaph.org>:
>> On Wed, Sep 10, 2008 at 09:03:05AM +0100, Mike Ralphson wrote:
>>> 2008/9/7 Arjen Laarhoven <arjen@yaph.org>
>>> > The standard libc regex library on OSX does not support alternation
>>> > in POSIX Basic Regular Expression mode.  This breaks the diff.funcname
>>> > functionality on OSX.
>>> >
>>> > Also, I'm sure the problem occurs on more non-Linux systems (or non
>>> > GNU libc systems).  If people who have access to those systems (BSD's,
>>> > HP-UX, AIX, etc) can test it, I'd be happy to add those systems to the
>>> > patch so it can fix for multiple systems at once.
>>>
>>> I can confirm that the issue shown up by your new testcase is also
>>> present in AIX 5.3.
>
>>> Adding -lcompat/regex to COMPAT_CFLAGS as per your Darwin hunk
>>> provokes lots of warnings:
>>
>> I think your problem is a lowercase ell instead of an uppercase i ;-)
>
> Doh. I think my problem is this font! And having not used a language
> with a separate linker since last century.
>
> I guess I picked a really bad patch to try and pick up and test direct
> from gmail. No reflection on your patch, just my workflow.
>
> Having carefully checked the content of the testcase too, I can now
> say this does fix the issue without extra warnings or testcase
> failures on AIX 5.3, so for what it's worth:
>
> Tested-by: Mike Ralphson <mike@abacus.co.uk>

Junio, sorry, I should have made this clear, but as above in the
thread, Johannes Sixt's 'patchlet' is required to be squashed into
3632cfc24, and I think Arjen was going to re-roll the patch.

I can submit the required follow-up, but it really should have J6's S-o-b.

Mike