From: Mike Ralphson <mike.ralphson@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git list <git@vger.kernel.org>, Daniel Stenberg <daniel@haxx.se>,
Nick Hengeveld <nickh@reactrix.com>,
Mike Hommey <mh@glandium.org>
Subject: Re: Minimum libCurl version for git
Date: Mon, 23 Mar 2009 11:24:57 +0000 [thread overview]
Message-ID: <e2b179460903230424v1c98d73ci1f41918807fb2d5c@mail.gmail.com> (raw)
In-Reply-To: <7vy6uzg98v.fsf@gitster.siamese.dyndns.org>
2009/3/20 Junio C Hamano <gitster@pobox.com>:
> We can have these two macro definitions on our side
>
> #if curl older than 7.10.8
> #define CURLINFO_RESPONSE_CODE CURLINFO_HTTP_CODE
> #endif
>
> #if curl older than 7.9.7
> #define CURLOPT_READDATA CURLOPT_INFILE
> #endif
>
> for backward compatibility, while writing our code to the recent API by
> using CURLINFO_RESPONSE_CODE and CURLOPT_READDATA, and people with older
> curl would not have to suffer a bit.
See? That's why they pay you the big maintainer-bucks... 8-)
> Mike, I'd say we declare 7.9.3 as the floor and go from there. That's
> your #3, I think.
Short patch series to follow, though maybe not today.
Mike
next prev parent reply other threads:[~2009-03-23 11:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 17:59 Minimum libCurl version for git Mike Ralphson
2009-03-20 21:44 ` Junio C Hamano
2009-03-20 22:13 ` Mike Hommey
2009-03-20 22:31 ` Daniel Stenberg
2009-03-20 22:58 ` Junio C Hamano
2009-03-23 11:24 ` Mike Ralphson [this message]
2009-03-24 7:35 ` Junio C Hamano
2009-03-20 22:15 ` Daniel Stenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2b179460903230424v1c98d73ci1f41918807fb2d5c@mail.gmail.com \
--to=mike.ralphson@gmail.com \
--cc=daniel@haxx.se \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
--cc=nickh@reactrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).