From: Mike Ralphson <mike.ralphson@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] t3702: fix reliance on SHELL_PATH being '/bin/sh'
Date: Mon, 27 Apr 2009 19:01:08 +0100 [thread overview]
Message-ID: <e2b179460904271101r6b405595yd4ad3562633eae60@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0904271940100.7741@intel-tinevez-2-302>
2009/4/27 Johannes Schindelin <Johannes.Schindelin@gmx.de>:
> Trying to be lazy and comparing files with fake-editor.sh to avoid
> having to provide another example text does not work well: the blob
> name changes when SHELL_PATH changes, and so does the 'index' line
> in the diff.
>
> Aargh.
>
> I know what it is. Sorry, _very_ stupid thinko on this side of
> the ocean.
>
> Time for a day off.
I shall merely extend my thanks for diagnosing the problem (which I
should have been able to do), and for fixing it - which I wouldn't
have been able to do, because I'd assumed you were trying to be
clever, not lazy. 8-)
Tested-by: Mike Ralphson <mike@abacus.co.uk>
prev parent reply other threads:[~2009-04-27 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 15:12 t3702-add-edit.sh failure in next Mike Ralphson
2009-04-27 16:13 ` Johannes Schindelin
2009-04-27 16:30 ` Mike Ralphson
2009-04-27 17:51 ` [PATCH] t3702: fix reliance on SHELL_PATH being '/bin/sh' Johannes Schindelin
2009-04-27 18:01 ` Mike Ralphson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2b179460904271101r6b405595yd4ad3562633eae60@mail.gmail.com \
--to=mike.ralphson@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).