From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] Transitively read alternatives
Date: Sun, 07 May 2006 20:28:25 +0200 [thread overview]
Message-ID: <e3le7q$eli$1@sea.gmane.org> (raw)
In-Reply-To: 20060507181920.GC23738@admingilde.org
Martin Waitz wrote:
> When adding an alternate object store then add entries from its
> info/alternates files, too.
> Relative entries are only allowed in the current repository.
> Loops and duplicate alternates through multiple repositories are ignored.
> Just to be sure that nothing breaks it is not allow to build deep
> nesting levels using info/alternates.
> + if (depth > 5) {
> + error("%s: ignoring alternate object stores, nesting too deep.",
> + relative_base);
> + return;
> + }
Please, no magic numbers. Use preprocesor "constants" for that.
--
Jakub Narebski
Warsaw, Poland
next prev parent reply other threads:[~2006-05-07 18:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-07 18:19 [PATCH] Transitively read alternatives Martin Waitz
2006-05-07 18:28 ` Jakub Narebski [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-05-01 20:36 Martin Waitz
2006-05-01 20:56 ` Junio C Hamano
2006-05-01 22:53 ` Martin Waitz
2006-05-02 7:38 ` Martin Waitz
2006-05-03 4:28 ` Junio C Hamano
2006-05-03 7:51 ` Martin Waitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e3le7q$eli$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).