From: Guanqun Lu <guanqun.lu@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] fix typo in Documentation
Date: Thu, 5 Feb 2009 14:27:41 +0800 [thread overview]
Message-ID: <e57070790902042227r2d571b94h9b3a997d826a80d2@mail.gmail.com> (raw)
In-Reply-To: <m38womwo2b.fsf@localhost.localdomain>
On Wed, Feb 4, 2009 at 5:26 PM, Jakub Narebski <jnareb@gmail.com> wrote:
> Guanqun Lu <guanqun.lu@gmail.com> writes:
>
>> Signed-off-by: Guanqun Lu <guanqun.lu@gmail.com>
>> ---
>> Documentation/technical/api-strbuf.txt | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Minor nit: I would add _where_ did you fix typy, i.e. instead of just
> fix typo in Documentation
> I'd use
> fix typo in strbuf API documentation
OK. I'll keep an eye next time. And thanks for your advice.
>
> --
> Jakub Narebski
> Poland
> ShadeHawk on #git
>
--
Guanqun
next prev parent reply other threads:[~2009-02-05 6:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 21:00 [PATCH 1/2] fix typo in Documentation Guanqun Lu
2009-02-04 5:30 ` Sverre Rabbelier
2009-02-04 9:26 ` Jakub Narebski
2009-02-05 6:27 ` Guanqun Lu [this message]
2009-02-04 21:00 ` [PATCH 2/2] add test-dump-cache-tree in Makefile Guanqun Lu
2009-02-04 7:46 ` Junio C Hamano
2009-02-04 9:31 ` Jakub Narebski
2009-02-06 13:43 ` [PATCH 1/2] fix typo in Documentation Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e57070790902042227r2d571b94h9b3a997d826a80d2@mail.gmail.com \
--to=guanqun.lu@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).