From: Marco Costalba <mcostalba@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-commit: revamp the git-commit semantics.
Date: Sun, 5 Feb 2006 14:36:51 +0100 [thread overview]
Message-ID: <e5bfff550602050536j73f1091dq9afae232f574d0b4@mail.gmail.com> (raw)
In-Reply-To: <7vpsm2hzng.fsf@assigned-by-dhcp.cox.net>
On 2/5/06, Junio C Hamano <junkio@cox.net> wrote:
> I am addressing people who participated with their valuable
> inputs to the earlier "git commit" discussion.
>
> Here is my first cut. I'd appreciate to hear from both
> git-experienced people and git newcomers how comfortable this
> new implementation is. Improvement patches on top of this are
> certainly appreciated.
>
I think the new semantics is clear and better then old one, especially
for people coming from different scm systems.
Unfortunately it breaks qgit commit functionality. So I would like to
ask _how_ do you plan to update main line.
I would like to update qgit also today, but it is impossible because
"git-commit -i" _currently_ raises an error. So I am just wondering
if adding a temporary -i "no op" option to _current_ git-commit, until
semantics change is released could be done.
Adding a -i "place holder" option to _current_ git-commit has the
following advantages:
1) No functionality change and 100% compatibility with current git-commit use.
2) Give people time to update tools/script in the mean time
3) When the real patch will be released all the (modified) tools will
be automatically compatible.
What do you think?
Marco
next prev parent reply other threads:[~2006-02-05 13:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-05 10:24 [PATCH] git-commit: revamp the git-commit semantics Junio C Hamano
2006-02-05 13:36 ` Marco Costalba [this message]
2006-02-05 20:03 ` Junio C Hamano
2006-02-05 22:08 ` Marco Costalba
2006-02-05 23:10 ` Junio C Hamano
2006-02-07 16:59 ` Nicolas Pitre
2006-02-07 17:50 ` Junio C Hamano
2006-02-07 18:18 ` Junio C Hamano
2006-02-07 19:25 ` Jon Loeliger
2006-02-07 18:39 ` Nicolas Pitre
2006-02-07 19:18 ` Nicolas Pitre
2006-02-08 5:41 ` Junio C Hamano
[not found] ` <20060205225116.GC24561@blinkenlights.visv.net>
2006-02-06 0:03 ` Junio C Hamano
2006-02-06 1:32 ` Junio C Hamano
2006-02-06 2:25 ` Michael Fischer
2006-02-06 7:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550602050536j73f1091dq9afae232f574d0b4@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).