Fwd: More qgit defects 2/2

["Marco Costalba" <mcostalba@gmail.com>]

I would like to forward this thread to the list in case someone find
it interesting and/or suggests improvements.

---------- Forwarded message ----------
From: Marco Costalba <mcostalba@gmail.com>
Date: Apr 30, 2006 10:11 AM
Subject: Re: More qgit defects
To: Pavel Roskin <proski@gnu.org>
Cc: ydirson@altern.org


Hi Pavel,
>
> I think the list items in the file window need a pop-up menu.  Without
> it, the users would not be able to discover what e.g. the double click
> would do.
>

yes, I agree.

> More generally, I feel that something is wrong with the user interface.
> I think gitk is doing it better with a single pane that has the comments
> and the diff.  Splitting the window horizontally in three panes seems to
> be too much, especially when one of the panes is used for diffs.
>

Please Pavel pull from latest qgit repo. I just pushed a patch that,
at least for my
browsing style, fixes this and IMHO is better then gitk.

Patch description is as follow:
"Usability enhancement: use 'P' key to quick toggle patch viewer

   One of the limitation of patch browsing in qgit is the use of two
   frames, one for revision logs and the other for patch viewer.

   If patch viewer is docked the space is normally limited by revision
   log frame. If patch viewer is undocked it is always at top level and
   hides main view and revision logs.

   So this patch adds a new key binding 'P' that hides/unhides diff
   viewer window.

   The intended use is simple: open patch viewer and undock it so to cover
   a good chunk of screen space, then press 'P' key and diff viewer will
   disappear.

   Now you can browse the revisions as usual and toggle diff viewer with 'P'
   key so to easily view both logs and patches without any space constrains.
"

After a little bit of using I have found this way very natural, quick
and, especially important for me, do not compromise patch view size.

What I do is to size the undocked patch viewer on my left screen, and
toggle the P key, but other adjustment are possible, see:

http://digilander.libero.it/mcostalba/qgit_P_1.png
http://digilander.libero.it/mcostalba/qgit_P_2.png

Tip: let your mouse be always over main list view so that patch view
does not steal the focus and you can browse only with keyboard arrows
as well with new key bindings (see F1).

Let me know what you think.

               Marco