From: "Marco Costalba" <mcostalba@gmail.com>
To: "Josef Weidendorfer" <Josef.Weidendorfer@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Remove dead code after direct graph drawing
Date: Sat, 21 Oct 2006 21:33:14 +0200 [thread overview]
Message-ID: <e5bfff550610211233i1af1c6a5nf2d50a6759dab061@mail.gmail.com> (raw)
In-Reply-To: <200610211740.26128.Josef.Weidendorfer@gmx.de>
>
> On the first pass down, the memory increases by around 26 MB,
> which could by correct, as you do setupData() lazy (no idea what
> this function does...).
Populates the list view item and calculates (only calculation not
drawing) the graph of the item (see Git::updateLanes() )
> >
> > I'm not sure it depends on your patch though.
>
> Can you compare with/without my patch?
Yes. You are right, I have a memory increase also without your last patch.
>
> How did you check for leaks in the past?
> Did you try valgrind (memcheck or massif)?
>
I tried with valgrind but with little success due to a lot of noise
from qt libraries. Perhaps I was not using it right.
Sorry for the noise
Marco
prev parent reply other threads:[~2006-10-21 19:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 14:13 [PATCH 2/2] Remove dead code after direct graph drawing Josef Weidendorfer
2006-10-19 23:11 ` Josef Weidendorfer
2006-10-20 11:49 ` Marco Costalba
2006-10-20 16:01 ` Jakub Narebski
2006-10-21 6:35 ` Marco Costalba
2006-10-21 15:40 ` Josef Weidendorfer
2006-10-21 19:33 ` Marco Costalba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550610211233i1af1c6a5nf2d50a6759dab061@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=Josef.Weidendorfer@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).