git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Marco Costalba" <mcostalba@gmail.com>
To: "Josef Weidendorfer" <Josef.Weidendorfer@gmx.de>
Cc: "Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH qgit] Change also tag marks when changing graph size
Date: Tue, 24 Oct 2006 21:45:02 +0200	[thread overview]
Message-ID: <e5bfff550610241245r73b594ftf2cd39f4194b5411@mail.gmail.com> (raw)
In-Reply-To: <200610242041.22230.Josef.Weidendorfer@gmx.de>

On 10/24/06, Josef Weidendorfer <Josef.Weidendorfer@gmx.de> wrote:
> On Tuesday 24 October 2006 18:47, Marco Costalba wrote:
> > When changing graph size with CTRL+ and CTRL-
> > update also tag/branch marks.
> >
> > Also little cleanup.
> > ---
> >
> > Hi Josef,
> >
> >   please tell me if you are working on the same files, in this case I
> > will step back and wait you to finish your patch series and eventually
> > resubmit this one at the end.
>
> No, that is fine. Currently, I have not much time.
> Just curious: What did you expect next in my patch series? :-)
>

Quoting from your last e-mail:
"The new painting code regroups the drawing commands in
multiple switch-statements to prepare for far simpler code
with booleans for different elements, and not one type only."

Indeed it's not clear to me what the above line means exactly, it just
smells like there is something more cooking. Sorry If I've
misunderstood.

> Now that everything is drawn directly, the question is what to do with
> the new flexibility. E.g. we _could_ implement different
> graph drawing algorithms next to the original qgit one,
> e.g. mimicking gitk.

One little secret of current algorithm is that it just needs to know
the "state" of previous revision graph to calculate the next one. (see
Git::updateLanes() and lanes.cpp), it's a kind of a "rasterized" graph
drawing, i.e. line by line.

I didn't studied gitk in deep but it seems a little bit less simpler.
Anyway if you are interested it's for sure worth trying ;-)


  reply	other threads:[~2006-10-25 18:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-24 16:47 [PATCH qgit] Change also tag marks when changing graph size Marco Costalba
2006-10-24 18:41 ` Josef Weidendorfer
2006-10-24 19:45   ` Marco Costalba [this message]
2006-10-25  2:20     ` Josef Weidendorfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5bfff550610241245r73b594ftf2cd39f4194b5411@mail.gmail.com \
    --to=mcostalba@gmail.com \
    --cc=Josef.Weidendorfer@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).