From: "Marco Costalba" <mcostalba@gmail.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: "Catalin Marinas" <catalin.marinas@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Print progress message to stderr, not stdout
Date: Sat, 2 Dec 2006 14:20:07 +0100 [thread overview]
Message-ID: <e5bfff550612020520w3ad48a09xfdde63b9050a75cf@mail.gmail.com> (raw)
In-Reply-To: <20061111121625.8988.45195.stgit@localhost>
On 11/11/06, Karl Hasselström <kha@treskal.com> wrote:
> Printing progress messages to stdout causes them to get mixed up with
> the actual output of the program. Using stderr is much better, since
> the user can then redirect the two components separately.
>
This patch breaks qgit.
GUI interface to stgit pop and push commands is broken because a
command that prints to stderr is considered a failing one by qgit.
I would kindly ask you to:
1 - Revert the patch. That would be the best. You can use a prefix to
printed message instead, see git pull, something like 'stg: bla bla
bla' . In any case, IMHO, using stderr for normal activity logging
does not sound like a great idea in general.
2 - At least add a '-v' '--verbose' option that defaults to quiet so
to not break back compatibility.
Thanks
Marco
P.S: I cannot change the stderr == 'something has gone wrong'
behaviour because the interface to git commands works with this, and,
BTW, _all_ the git commands respect the behaviour stderr == empty ->
next prev parent reply other threads:[~2006-12-02 13:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-11 12:16 [PATCH] Print progress message to stderr, not stdout Karl Hasselström
2006-12-02 13:20 ` Marco Costalba [this message]
2006-12-04 9:17 ` Catalin Marinas
2006-12-04 15:37 ` Karl Hasselström
2006-12-04 18:34 ` Marco Costalba
2006-12-04 22:13 ` Catalin Marinas
2006-12-05 6:11 ` Marco Costalba
2006-12-05 7:41 ` Johannes Schindelin
2006-12-05 9:06 ` Karl Hasselström
2006-12-05 9:06 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550612020520w3ad48a09xfdde63b9050a75cf@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).