From: "Marco Costalba" <mcostalba@gmail.com>
To: "Andy Parkins" <andyparkins@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] Wrap the log text in some nice HTML to highlight the commit message
Date: Fri, 23 Feb 2007 09:03:10 +0100 [thread overview]
Message-ID: <e5bfff550702230003o5a24a422h7c52a544318da1d4@mail.gmail.com> (raw)
In-Reply-To: <200702181044.53115.andyparkins@gmail.com>
On 2/18/07, Andy Parkins <andyparkins@gmail.com> wrote:
> On Sunday 2007, February 18, Marco Costalba wrote:
>
> > thanks for your patches, but I can see only this email and the
> > '[PATCH 2/3] Improve default column widths by changing resize modes',
> > I miss body of [PATCH 1/3] and [PATCH 3/3].
>
> I think that the mailing list spam filter is objecting because the email
> contains HTML tags. I'll send the patches to you directly to bypass
> the spam filter.
>
>
Hi Andy,
I finally apply and pushed your patches to
git://repo.or.cz/qgit4.git, I have to say I really like your fancy
html log message.
Just a couple of notes:
- Font family is set to TYPE_WRITER_FONT, but font size is not taken
into account and seems fixed.
- There are some alignement issues in the header, sometimes author,
date, etc.. are left shifted without a clear reason wasting valuable
screen space.
Here are some snapshots to better clarify the points.
http://digilander.libero.it/mcostalba/andy1.png
http://digilander.libero.it/mcostalba/andy2.png
http://digilander.libero.it/mcostalba/andy3.png
Anyway a nice job.
Thanks
Marco
next prev parent reply other threads:[~2007-02-23 8:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200702172200.13461.andyparkins@gmail.com>
2007-02-17 22:02 ` [PATCH 1/3] Wrap the log text in some nice HTML to highlight the commit message Andy Parkins
2007-02-18 7:25 ` Marco Costalba
2007-02-18 10:44 ` Andy Parkins
2007-02-23 8:03 ` Marco Costalba [this message]
2007-02-23 10:02 ` Andy Parkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550702230003o5a24a422h7c52a544318da1d4@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).