git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Marco Costalba" <mcostalba@gmail.com>
To: "Andy Parkins" <andyparkins@gmail.com>
Cc: git@vger.kernel.org, "Pavel Roskin" <proski@gnu.org>
Subject: Re: [RFH] QGit: how to cram a patch in a crowded screen
Date: Sat, 26 May 2007 22:44:28 +0200	[thread overview]
Message-ID: <e5bfff550705261344l604543e7h64c20c1fc0979f20@mail.gmail.com> (raw)
In-Reply-To: <200705261034.53723.andyparkins@gmail.com>

On 5/26/07, Andy Parkins <andyparkins@gmail.com> wrote:
>
> For example, the log view widget would show:
>
> <Header>
> <Log Message>
> <Patch>
>
> All visually distinct to improve searching by eye (perhaps including
> clear separators between files patched).  Then the file list could
> include a "<header>" psuedo-file that would jump back to the top of the
> viewer.
>

This seems really gitk like. Not that I don' t like it, but _if_ it's
possible I would prefer something a little bit more original.

>
> Here's another option, keeping the patch tab, but putting the tab widget
> in the log view window.  That way the list would be visible and you
> would just switch between the log and the patch.
>

Yes. More or less along the lines of an handful of patches I've just
pushed to git://git.kernel.org/pub/scm/qgit/qgit4.git

Now user can toggle between revision commit message and patch content
with the menu entry 'View->toggle message/diff', or with shortcut 'm'
or also with mouse clicking on top right links 'Diff->' and 'Log->'.

There is also a check box in 'Edit->settings' called 'Show always
revision message as first' that, if set, let automatically to switch
to revision message when browsing on a new revision.

With this, browsing on a repo reading both log message and patch it's
a matter of 2 clicks or 2 shortcuts per revision, one for changing
revision (and read the log message) and another to view the patch
content.

This is a good speedup from before when we needed 3 commands, one for
selecting the rev, one for switching to patch tab and viewing the diff
and one for switching back to main list.


Comments? like/dislike?

Thanks
Marco

  reply	other threads:[~2007-05-26 20:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-26  8:46 [RFH] QGit: how to cram a patch in a crowded screen Marco Costalba
2007-05-26  9:34 ` Andy Parkins
2007-05-26 20:44   ` Marco Costalba [this message]
2007-05-27 15:38     ` Jan Hudec
2007-05-27 15:56       ` Marco Costalba
2007-05-31 19:56         ` Jan Hudec
2007-06-02 11:37           ` Marco Costalba
2007-06-04 15:41             ` Jan Hudec
2007-05-30 13:08     ` Andy Parkins
2007-05-30 18:18       ` Marco Costalba
2007-05-31  0:23         ` Pavel Roskin
2007-05-31  4:39           ` Marco Costalba
2007-05-31  9:27           ` Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5bfff550705261344l604543e7h64c20c1fc0979f20@mail.gmail.com \
    --to=mcostalba@gmail.com \
    --cc=andyparkins@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=proski@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).