Re: Finally implement "git log --follow"

["Marco Costalba" <mcostalba@gmail.com>]

On 6/20/07, Linus Torvalds <torvalds@linux-foundation.org> wrote:

>
> That said, you really would be better off using
>
>         git blame -M --incremental
>

That's how it is currently inplemented in qgit:

- Main view revision list + graph: git-rev-list
- File history and annotation: git-rev-list

The possible options are:

ALL GIT LOG
-------------------

- Main view revision list + graph: git-log
- File history and annotation: git-log

Good: easy implementation and a lot of common code to share among
modules, all the current features (see "range fltering" below) are
preserved

Bad: Currently git-log does not support --stdin option, required IMHO
when git-log is runned by a tool, not a user, due to the possibility
of a very long command line.

MIXED
---------

- Main view revision list + graph: git-rev-list
- File history and annotation: git-blame

Good: Gain additional features of git-blame against git-log

Bad: FWIK "git blame -M --incremental" does not support annotating all
the files in history in one go, as it is possible both with
git-rev-list and git-log. You have to re-annotate the new file when
browsing file history with the mouse.

Impementation cannot reuse big chunks of code, so a lot of new code is
needed and probably old one will not disappear.

FWIK "git blame -M --incremental" does not support "code lines range
filtering", when with the mouse you select some lines of code and
after filtering you see the subset of file's history that modified
that range of code. This feature is currently supported by qgit
annotating code.

Also jump to the same currently selected code line when switching to a
different version in file history it is currently supported by
annotate code.


INTERESTING
--------------------

- Main view revision list + graph: git-log
- File history and annotation: git-blame

A curious mix.



Some advice?


Thanks
Marco