git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Marco Costalba" <mcostalba@gmail.com>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: Possible BUG in 'git log -z' last commit is not '\0' terminated
Date: Sat, 23 Jun 2007 07:51:07 +0200	[thread overview]
Message-ID: <e5bfff550706222251kdc6ccb4s6caf0195682ab727@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.0.98.0706221451570.3593@woody.linux-foundation.org>

On 6/22/07, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> So you should think of the "\0" as being a delimeter that goes between
> commits, not something that "ends" the commit. It's not a "end of record"
> thing, it's a "between records" thing.
>

Thanks for explanation.

Interesting enough git-dif-tree with -z, documented as

"-z  \0 line termination on output"

has a different behaviour, with and without -p option:

git diff-tree -z HEAD ---> a '\0' is printed at the end

git diff-tree -z -p HEAD --> No '\0' is printed.

I suppose 'git log' passes '-z' to 'git diff-tree' because no
documentation exsists in 'git log' man page.

Thanks
Marco

BTW git-rev-list --header uses '\0' differently (appends to each
record), but that's another story.

      reply	other threads:[~2007-06-23  5:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-22 19:27 Possible BUG in 'git log -z' last commit is not '\0' terminated Marco Costalba
2007-06-22 21:29 ` Junio C Hamano
2007-06-22 21:56 ` Linus Torvalds
2007-06-23  5:51   ` Marco Costalba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5bfff550706222251kdc6ccb4s6caf0195682ab727@mail.gmail.com \
    --to=mcostalba@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).