From: "Marco Costalba" <mcostalba@gmail.com>
To: "Jan Hudec" <bulb@ucw.cz>
Cc: git@vger.kernel.org
Subject: Re: [Qgit RFC] commit --amend
Date: Fri, 6 Jul 2007 10:12:50 +0200 [thread overview]
Message-ID: <e5bfff550707060112p29b9565bw9ccba6601745b850@mail.gmail.com> (raw)
In-Reply-To: <20070705185426.GB3991@efreet.light.src>
On 7/5/07, Jan Hudec <bulb@ucw.cz> wrote:
>
> Therefore I'll either have to always ask git via run("git-rev-parse HEAD",
> head), add HEAD into the map, or store HEAD somewhere in the Git object.
> Which do you think makes most sense?
>
Asking git when you need it and keep HEAD value only for the minimum
time required to execute the commit command.
- HEAD is very 'volatile'
- commit is _not_ performance critical.
- commit, being a write operation, is instead bugs/misbehaviour
critical (a big point to use an high level "git-commit" BTW)
- asking git with getRefSha("HEAD", ANY_REF, true) is very quick and
in any case much quicker then the whole commit dance.
- someone can always change the repo behind you, qgit is not the only
interface to git ;-) does exist also the command line.
Marco
next prev parent reply other threads:[~2007-07-06 8:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-10 15:08 [Qgit RFC] commit --amend Jan Hudec
2007-06-10 22:10 ` Marco Costalba
2007-06-11 4:42 ` Jan Hudec
2007-06-11 5:24 ` Marco Costalba
2007-06-11 5:45 ` Marco Costalba
2007-07-01 12:26 ` Jan Hudec
2007-07-01 16:09 ` Marco Costalba
2007-07-02 18:03 ` Jan Hudec
2007-07-04 5:10 ` Junio C Hamano
2007-07-04 12:44 ` Marco Costalba
2007-07-04 18:28 ` Jan Hudec
2007-07-04 19:51 ` Junio C Hamano
2007-07-06 7:54 ` Marco Costalba
2007-07-05 18:54 ` Jan Hudec
2007-07-06 8:12 ` Marco Costalba [this message]
2007-07-08 13:38 ` Jan Hudec
2007-07-08 13:49 ` Marco Costalba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bfff550707060112p29b9565bw9ccba6601745b850@mail.gmail.com \
--to=mcostalba@gmail.com \
--cc=bulb@ucw.cz \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).